summaryrefslogtreecommitdiffstats
path: root/src/remote-viewer.c
Commit message (Collapse)AuthorAgeFilesLines
* remote-viewer: Remove unused propertiesEduardo Lima (Etrunko)2016-02-181-97/+4
| | | | | | | | The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Port to GtkApplication API'sEduardo Lima (Etrunko)2016-02-181-33/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is now a subclass of GtkApplication. Some mainloop calls were replaced: * gtk_main() -> g_application_run() * gtk_quit() -> g_application_quit() - Unified command line option handling. The logic has moved from the main functions and split in common options, and specific ones for each application. With this, the main functions were highly simplified, and now basically responsible for instantiating the App object and running the main loop. - All Window objects must be associated with the Application. With this, there is no need to emit our own 'window-added'/'window- removed' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Minor code cleanupsEduardo Lima (Etrunko)2016-02-151-6/+7
| | | | | | | | - Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* remote-viewer-connect: Changed dialog into a windowLukas Venhoda2015-06-161-3/+1
| | | | | | Changed connect dialog from GtkDialog to a GtkWindow. Added the necessary signals and buttons, to keep the behaviour of a dialog. (ESC to close, ENTER to submit)
* remote-viewer-connect: Changed response to gbooleanLukas Venhoda2015-06-161-1/+1
| | | | | | remote_viewer_connect_dialog now returns TRUE and FALSE, instead of 0 and -1. Added a doxygen style comment to document this in code also.
* remote-viewer: Connect dialog moved to its own fileLukas Venhoda2015-06-161-158/+2
| | | | | | | | Connect dialog from remote-viewer is now in its own file. Most other dialog also have their own files. This will make changing the dialog into a window easier. Renamed connect_dialog to remote_viewer_connect_dialog.
* ovirt: Allow to cancel authentication without showing error dialogPavel Grunt2015-04-141-0/+12
| | | | Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201604
* remote-viewer: Avoid simple_message_dialog() when errors can be propagatedFabiano Fidêncio2015-03-271-1/+1
| | | | | | | Remove the dialog used to report errors when create_session() fails, propagating the error is enough and it is already done. Related: rhbz#1085216
* virt-viewer-app: create_session() should return a booleanFabiano Fidêncio2015-03-271-3/+3
| | | | | | | By convention functions that take GError parameters should return FALSE (or NULL) or error. Related: rhbz#1085216
* virt-viewer-app: Add a GError arg to create_session()Fabiano Fidêncio2015-03-271-10/+4
| | | | | | | | | | | This is part of a small re-factoring that will have all connection errors, when we won't be able to connect regardless of what changes on the remote host, being treated by virt_viewer_app_initial_connect(), avoiding weird behaviors as we have nowadays (like more than one error dialog being shown or having the virt-viewer waiting forever for a guest that will never show up). Related: rhbz#1085216
* Report errors in one placePavel Grunt2015-03-231-12/+13
| | | | | | Since the error is propagated to the main, report the error there. To make it work GError VIRT_VIEWER_ERROR_FAILED is set for all failing states and it is reported using virt_viewer_app_simple_message_dialog().
* Exit normally when canceling dialogPavel Grunt2015-03-231-9/+14
| | | | | | | | | This applies for: libvirt authentication dialog (e.g. virt-viewer --attach guest) 'recent connection' dialog (e.g. remote-viewer) 'vm choose' dialog when connecting without specifying the vm name This is done by using a new GError VIRT_VIEWER_ERROR_CANCELLED.
* ovirt: Don't try to use invalid port numbersChristophe Fergeau2015-03-131-2/+6
| | | | | | | | If a remote oVirt VM don't specify a port/secure port number, we'd still try to pass it down to spice-gtk, which would then complain that 0 (the default value) isn't a valid port number. This commit make sure we filter out the default port/secure-port value and pass NULL to spice-gtk instead when we get these values.
* foreign-menu: Don't show empty foreign menu on secondary displaysChristophe Fergeau2015-03-131-1/+6
| | | | | | | | | | When using ovirt://, the foreign menu will only be shown in the primary window after getting notified about OvirtForeignMenu::files (ie when it managed to fetch some ISO files to show in the foreign menu). However, for secondary windows, the foreign menu will be added to the window even if there are no files to show. This commit makes sure we destroy the window foreign menu whenever it would be empty.
* ovirt: Fail gracefully when hostname is missingChristophe Fergeau2015-03-121-0/+7
| | | | | | | When parsing info returned by oVirt REST API, the hostname should be present. However, I recently run remote-viewer against a buggy oVirt instance where the hostname was missing. This commit handles better this situation by displaying an error message and exiting.
* ovirt: Take into account SPICE proxyChristophe Fergeau2015-03-121-0/+4
| | | | | | | | | | | VMs managed by oVirt can be hidden behind a proxy. This commit allows remote-viewer to make use of this information when it's available A recent oVirt instance is needed so that it's available through the REST API, as well as libgovirt 0.3.3 or newer. With older oVirt/libgovirt versions, the worst that can happen is a runtime warning in the console, and an impossibility to connect to VMs behind a proxy, so this commit is not raising the minimum libgovirt requirement.
* Do not add "https://" and "/api" to oVirt URIPavel Grunt2015-02-181-3/+2
| | | | | | | | | It is deprecated since govirt 0.3.1 (and virt-viewer already depends on govirt 0.3.2). Silences: (remote-viewer:19420): libgovirt-WARNING **: Passing a full http:// or https:// URI to ovirt_proxy_new() is deprecated (remote-viewer:19420): libgovirt-WARNING **: Passing an URI ending in /api to ovirt_proxy_new() is deprecated
* Set a transient parent for GtkDialogsPavel Grunt2014-12-191-8/+22
| | | | | Silence the Gtk 3.14 message: "GtkDialog mapped without a transient parent. This is discouraged."
* Remove VIRT_VIEWER_VM_CHOOSE_DIALOG_CANCELLEDMarc-André Lureau2014-11-251-9/+3
| | | | | | This error type isn't really an error, it is used to skip error report code. The functions can simply return FALSE on failure, without GError set, to indicate that program should quit normally.
* Avoid use of non-literal string with g_debugDaniel P. Berrange2014-10-271-2/+2
|
* Remove useless 'if (...)' before free()Daniel P. Berrange2014-10-271-3/+1
| | | | | The 'free()' function accepts NULL, so you should not check for NULL before calling it.
* Prefill the username in the authentication dialogFabiano Fidêncio2014-10-101-0/+3
| | | | | Lets prefill the username entry using the user name of the current user.
* Show VM chooser dialog when oVirt VM name is missingPavel Grunt2014-10-101-22/+103
| | | | | | | When a user tries to connect to ovirt without specifying VM name (remote-viewer ovirt://ovirt.example.com) or with wrong VM name a list of available virtual machines is shown, and the user may pick a machine he wants to connect to.
* VirtViewerApp: store windows in a listJonathon Jongsma2014-09-241-12/+9
| | | | | Use a list to store the application's windows. This is another step towards separating the window from the guest display ID.
* Fix --without-spice-gtk --with-ovirt buildChristophe Fergeau2014-09-121-47/+60
| | | | | | | | | | | | | | | | | | The oVirt foreign menu support reused some existing bits from the older SPICE controller foreign menu code. However, this controller code is only built when spice-gtk support is built, while the oVirt foreign menu code could be used with VNC as well. Trying to build the ovirt foreign menu code without spice-gtk causes build issues due to missing functions, or missing declarations, ... The libgovirt/spice-gtk code which is entangled is the code to update the foreign menu when its content changes, or when a new window is opened. Making the oVirt-specific code independant from the spice-gtk-specific code is not too complicated, but this comes at the expense of a bit of code duplication, but this is only simple code iterating over the GHashTable storing the opened windows. Resolves: rhbz#1127156
* Change collect_credentials() to return a booleanJonathon Jongsma2014-08-261-3/+4
| | | | | | Instead of returning 0 for success and -1 for failure, change to a boolean success value to be more consistent with the rest of the virt-viewer code.
* Auth: fix leak of usernameJonathon Jongsma2014-08-261-6/+5
| | | | | When collect_credentials() returns a failure status, 'username' was potentially leaked.
* remote-viewer: oVirt username review fixesJonathon Jongsma2014-08-191-2/+3
| | | | | | Minor fixes from patch review rhbz#1061826
* Create foreign menu from .vv file informationChristophe Fergeau2014-08-181-0/+9
| | | | | | | | | | | | | When the .vv file has an [ovirt] section, we should try to create a foreign menu out of it. This will allow remote-viewer to offer a menu to change the currenty inserted cdrom. Contrary to the ovirt:// case when we already have fetched an OvirtAPI and OvirtVm instance in order to get the SPICE/VNC connection details, when working from a .vv file, we'll need to get them from the REST API. Authentication should happen through the JSESSIONID cookie, if that fails we want to give up on using the foreign menu, so we don't need to set up authentication callbacks.
* ovirt: Use OvirtForeignMenu classChristophe Fergeau2014-08-181-0/+82
| | | | | After the previous commit which introduced the OvirtForeignMenu class, we can now make use of it in the remote-viewer UI code.
* ovirt: Remove extra '/' from oVirt URIChristophe Fergeau2014-08-181-1/+2
| | | | | | | | | | | | The 'path' part of the URI will always start with a '/' when present as this is what separates it from the hostname. When rebuilding the final URI, the current code inserts a '/' by itself between the hostname and the path, which results in URIs with an extra '/': https://ovirt.example.com//some/path/api This is not only cosmetic as this can cause issues with cookie handling if libgovirt accesses //some/path/api while the cookie is set for /some/path/api.
* remote-viewer: allow username in ovirt URIsJonathon Jongsma2014-08-181-4/+16
| | | | | | | | | | | | When the user launches remote-viewer with an ovirt URI of the form ovirt://user@host/vmname Pre-populate the authentication dialog with the specified username. We don't support specifying the password on the commandline, since that is a potential security risk. rhbz#1061826
* Remove unused RemoteViewerPrivate membersChristophe Fergeau2014-08-041-2/+0
|
* Remove incorrect G_GNUC_UNUSED from remote_viewer_window_addedChristophe Fergeau2014-08-041-1/+1
| | | | The 'app' parameter is used in the function.
* Replace DEBUG_LOG with g_debugMarc-André Lureau2014-06-101-3/+3
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1107518
* Set freed variables to NULL in remote_viewer_start()Jonathon Jongsma2014-06-031-0/+2
| | | | | | | Coverity warns that 'type' can sometimes be used or free after already having been freed. This can happen when open_recent_dialog is true and we jump back up to the retry_dialog label. To prevent this, make sure the freed variables are set to NULL after freeing.
* Improve remote-viewer connection dialogJonathon Jongsma2014-06-031-12/+75
| | | | Based on the new design for the 'connect to server' dialog from Nautilus.
* spice: do not open in fullscreen with CONTROLLER_AUTO_DISPLAY_RESMarc-André Lureau2014-02-261-1/+1
| | | | | | This flag is always set when using the rhevm user portal. Best is probably to ignore it, now that fullscreen has simplified unique behaviour.
* Improve window title when connected to newer spice-serverJonathon Jongsma2014-02-111-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recent spice servers send the guest vm name and uuid to the client. We can use these values to display the proper vm name in the window title if a title is not specified on the commandline. We can also be smarter about the title in virt-viewer as well. If a title is specified on the comamndline (-t/--title=foo), we use that. If not, we fall back to the vm name. If that is empty, we fall back to the uri of the connection. Comparison between old behavior and new behavior Using new spice-server Command Old title New title ------- --------- --------- remote-viewer -t xyz spice://host:port xyz xyz remote-viewer spice://host:port spice://host:port <vmname> virt-viewer <vmname> <vmname> <vmname> virt-viewer <uuid> <uuid> <vmname> Using old spice-server Command Old title New title ------- --------- --------- remote-viewer -t xyz spice://host:port xyz xyz remote-viewer spice://host:port spice://host:port spice://host:port virt-viewer <vmname> <vmname> <vmname> virt-viewer <uuid> <uuid> <vmname>
* Reshow connection dialog on errorsChristophe Fergeau2013-11-131-0/+5
| | | | | | | | | | | | | | | remote-viewer behaviour is currently inconsistent in the connection dialog: if the user enters a valid URI, but then remote-viewer fails to connect to it, then we'll show again the connection dialog through a call to virt_viewer_app_start() in remote_viewer_deactivated(). If instead we enter an invalid URI in the connection dialog, then remote-viewer will report an error and quit. This commit makes sure in the latter case, we report the error and show again the connection dialog. The user can press 'Cancel' in the connection dialog to get out of remote-viewer as in this case, we return directly FALSE rather than going through the cleanup: label and looping.
* Handle virt_viewer_app_start() errorsChristophe Fergeau2013-11-131-2/+3
| | | | | | | | | | | | | | | | | remote_viewer_deactivated() can be calling virt_viewer_app_start() without checking whether it returns TRUE or FALSE. It returns FALSE when it was not successful (when it failed to parse the URI to connect to for example, or whe the user presses Cancel in the connection dialog). This means that if the user starts remote-viewer, enters a valid URI in the connection dialog to which it cannot connect to (spice://example.com:999) and then presses Cancel in the connection dialog that appears after the connection failure, then remote-viewer will be sitting there with an empty window doing nothing. This commit ensures we chain to the parent class when virt_viewer_app_start() returns FALSE, which causes remote-viewer to exit.
* Fix window title after failed connectionChristophe Fergeau2013-11-131-1/+7
| | | | | | | | | | | | | When using the connection dialog, if the user picks an invalid URI first causing a failed connection, and then picks/enters a valid URI, remote-viewer window title will be set to the first invalid URI, not to the second one which was entered. As the user may have specified a window title to use on the command line (-t option), we need to be careful not to override that when setting the window title on the second attempt. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1024309
* Drop basic fullscreen modeJonathon Jongsma2013-11-131-3/+1
| | | | | | Remove the distinction between --full-screen and --full-screen=auto-conf. Just make --full-screen behave like auto-conf did. There's really no advantage to having two slightly different fullscreen startup modes.
* ovirt: Only set SPICE CA cert if it's non NULLChristophe Fergeau2013-10-301-3/+7
| | | | | | We currently reuse the oVirt CA cert for SPICE connection as well, but it may not be set. When this happens, we don't want to try to use it.
* ovirt: Don't automatically download CA certificateChristophe Fergeau2013-10-301-6/+0
| | | | | | | | | | | The CA certificate to use to authenticate the various hosts in an oVirt instance can be fetched from https://ovirt.example.com/ca.crt. However, the gio API we are using does not seem to be checking the server-side certificate of ovirt.example.com before connecting to it, which could lead to man-in-the-middle attacks. Now that the CA certificate to use can be specified from the command line using --ovirt-ca-file, we can remove this automatic fetching of the CA certificate.
* ovirt: Honour oVirt command line optionsChristophe Fergeau2013-10-301-0/+1
| | | | | | libgovirt 0.3.0 and newer can be passed from the commandline a CA certificate to use during SSL communications. This commit adds support for this option to remote-viewer.
* ovirt: Remove use of deprecated APIsChristophe Fergeau2013-10-301-3/+12
| | | | | ovirt_proxy_fetch_vms/ovirt_proxy_lookup_vm have been deprecated in govirt 0.3.0
* Clean-up spaces before/after URI in connection dialogChristophe Fergeau2013-10-291-0/+1
| | | | | | | | | | | When starting remote-viewer with no argument, a connection dialog is shown. If the URI the user types in this dialog as trailing or leading spaces, then connection will fail because remote-viewer will keep them as if they were significant. This commit makes sure we remove spaces at the beginning/end of the URI before trying to use it. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1024199
* Try to share more GOption code between r-v and v-vMarc-André Lureau2013-08-201-4/+2
|
* Fix build --without-spice-gtkMarc-André Lureau2013-06-281-29/+27
|
generated by cgit (git 2.34.1) at 2024-05-09 16:16:12 +0000