Auth: fix leak of username

When collect_credentials() returns a failure status, 'username' was
potentially leaked.

1 files changed, 5 insertions, 6 deletions

diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index cb43365..89ad227 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -744,17 +744,16 @@ authenticate_cb(RestProxy *proxy, G_GNUC_UNUSED RestProxyAuth *auth,
                                                    "oVirt",
                                                    NULL,
                                                    &username, &password);
-    if (ret < 0) {
-        return FALSE;
-    } else {
+    if (ret == 0) {
         g_object_set(G_OBJECT(proxy),
                      "username", username,
                      "password", password,
                      NULL);
-        g_free(username);
-        g_free(password);
-        return TRUE;
     }
+
+    g_free(username);
+    g_free(password);
+    return (ret == 0);
 }