summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* app, cosmetic: remove one unneeded level of identationHEADmasterFabiano Fidêncio2016-03-071-14/+14
| | | | | Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* app: monitor-config - do it all or nothingFabiano Fidêncio2016-03-071-3/+4
| | | | | | | | | | | | | Don't keep trying to use a monitor config when it already failed for one monitor, otherwise virt-viewer can end up in a situation where none of the displays are enabled but the program is still running. So, in case of any failure, let's skip the whole monitor config, forcing virt-viewer to use the "fallback" one instead. Resolves: rhbz#1315206 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* Refresh translations from ZanataFabiano Fidêncio2016-03-0495-19488/+20829
| | | | Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
* Use GResource for loading ui filesFabiano Fidêncio2016-03-0310-79/+67
| | | | | | | | | | Let's take advantage of GResource for loading ui files in a better and cleaner way than virt_viewer_util_load_ui() was doing. It also brings the benefit, at least for developers, of being able to test ui changes without having to "make install" virt-viewer. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* app: Remove useless libxml includesFabiano Fidêncio2016-03-031-3/+0
| | | | Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* about: Fix the program's name in the titleFabiano Fidêncio2016-03-031-1/+1
| | | | | | | | | | | Title currently says "About Glade". It's not a big deal because it's not actually shown anywhere, but just for correctness let's change it to "About Virt-Viewer". Thanks Jonathon Jongsma for pointing this out. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Don't open the default display while parsing command lineEduardo Lima (Etrunko)2016-02-261-1/+1
| | | | | | | | | Since commit a9ce19f it has not been possible to check app version from a tty without X session running. The issue is that gtk_get_option_group function opens the default display if passed TRUE as argument. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com> Acked-by: Fabiano Fidêncio <fidencio@redhat.com>
* session-vnc: Avoid depracated warnings on this fileFabiano Fidêncio2016-02-261-0/+3
| | | | | | | | | | This is a temporary solution for using autobuild.sh, as commit df403f5 introduced the -Wdeprecated-declarations and gtk-vnc provides a callback for getting authentication credentials which uses GValueArray, forcing virt-viewer to keep using g_value_array_get_nth(), which is deprecated. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* configure: Simplify libvirt/libvirt-glib handlingFabiano Fidêncio2016-02-252-5/+2
| | | | | | | | Merge libvirt and libvirt-glib checking in PKG_CHECK_MODULES, then we don't nee the LIBVIRT_GLIB_{CFLAGS,LIBS} in Makefile.am Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* wxi: virt-viewer depends on libvirt-glibFabiano Fidêncio2016-02-251-0/+2
| | | | | | | | Since 51ce01d virt-viewer depends again on libvirt-glib. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
* nsis: Add libvirt-glib-1.0-0.dllFabiano Fidêncio2016-02-251-0/+2
| | | | | | | | Since 51ce01d virt-viewer depends again on libvirt-glib. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
* Bring back libvirt-glib dependencyFabiano Fidêncio2016-02-257-501/+11
| | | | | | | | | | | | | | | libvirt-glib dependency was dropped in commit 296f91c in favor to maintain the full glib event loop integration into virt-viewer tree. This decision was taken because libvirt-glib was not mature enough at that time, which is not the case nowadays. The libvirt-glib version chosen as dependency (0.1.8) is the first release that includes the fixes for the glib event loop integration that were backported to virt-viewer last year. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
* README: update informationPavel Grunt2016-02-251-8/+5
| | | | | | Remove info about gtk versions Fix a typo Change link for spice-gtk widget
* cleanup: Don't use gtk_widget_modify_{fg,bg}()Fabiano Fidêncio2016-02-242-6/+20
| | | | | | | | | | | These function have been deprecated since Gtk 3.0 and is recommended to use _override_color() and _override_background_color() instead. As these new functions take a GdkRGBA as parameter, let's use gdk_rgba_parse() instead of gdk_color_parse(). Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Jonathon Jongsma <jjongsma@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* cleanup: Don't use GtkStockFabiano Fidêncio2016-02-246-30/+27
| | | | | | | | | | | | It has been deprecated since Gtk 3.10. New strings have been added as the GTK_STOCK_* defines had their translations done inside Gtk itself, but now the translations of the new added labels must be done by virt-viewer translators. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Jonathon Jongsma <jjongsma@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* cleanup: Drop old compatibilty codeFabiano Fidêncio2016-02-247-1363/+0
| | | | | | | | A few more pieces of old compatibility code can be dropped, as we already depend on GLib 2.38. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
* Use GDK_VERSION_MAX_ALLOWEDFabiano Fidêncio2016-02-241-1/+8
| | | | | | | In order to avoid using a too new Gtk API. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* Use GLIB_VERSION_MAX_ALLOWEDFabiano Fidêncio2016-02-241-1/+9
| | | | | | | In order to avoid using a too new GLib API. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* m4: Use -Wdeprecated-declarationsFabiano Fidêncio2016-02-241-1/+1
| | | | | | | | | | | | | | Let's enable deprecated-declarations warnings as we want to: 1) Avoid insert/maintain deprecated widgets/methods 2) Avoid adding widgets/methods that are too new, what could cause problems like virt-viewer not being able to build in a specific distro. Patches for making these two items possible are coming, introducing _VERSION_MAX_ALLOWED for both GLIB and GDK and removing (as much as possible) deprecated widgets/methods/structures. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* mingw: Bump msitools versionFabiano Fidêncio2016-02-241-1/+1
| | | | | | | Since commit 5d98df3 we depend on msitools 0.95-2. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* app: Don't leave a window opened in case of connection errorFabiano Fidêncio2016-02-241-1/+4
| | | | | | | | | | | | | | | | | | | | Since commit ed9b3f3 the main window is not hidden when disconnecting. But it also is not hidden when a connection error occurs, leaving a black display with a not so accurate message to the users in case they try to connect to a non-valid address from the remote-viewer connection window and in this case the main window (display #1) shuldn't be shown. The impetus for this chance is the following: - user runs remote-viewer without any argument - the remote-viewer connection window shows up - user attempts to connect to a non-valid address - a dialog pops up indicating a failure connecting to the graphic server - the main window shows up saying "Connecting to the graphic server" - user clicks 'Ok' - the main window stays there with the same message As a user, I expect the program to not show the main window in connecting failure cases. This patch accomplishes that.
* nsis: update nettle to 3.2.1Fabiano Fidêncio2016-02-241-4/+4
| | | | Use version 3.2.1, matching what currently is in f23.
* Drop old compatibility codeEduardo Lima (Etrunko)2016-02-187-123/+0
| | | | | | With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* remote-viewer: Remove unused propertiesEduardo Lima (Etrunko)2016-02-181-97/+4
| | | | | | | | The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Port to GtkApplication API'sEduardo Lima (Etrunko)2016-02-1811-405/+364
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is now a subclass of GtkApplication. Some mainloop calls were replaced: * gtk_main() -> g_application_run() * gtk_quit() -> g_application_quit() - Unified command line option handling. The logic has moved from the main functions and split in common options, and specific ones for each application. With this, the main functions were highly simplified, and now basically responsible for instantiating the App object and running the main loop. - All Window objects must be associated with the Application. With this, there is no need to emit our own 'window-added'/'window- removed' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* spice: vv-file: do not ignore usb-filterUri Lublin2016-02-181-0/+10
| | | | | | | Fixes rhbz#1309634 Signed-off-by: Uri Lublin <uril@redhat.com> Acked-by: Fabiano Fidêncio <fidencio@redhat.com>
* Minor code cleanupsEduardo Lima (Etrunko)2016-02-151-6/+7
| | | | | | | | - Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Drop support to gtk2Fabiano Fidêncio2016-02-1513-380/+52
| | | | | | | | The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* display: Use correct variable namePavel Grunt2016-02-151-1/+1
| | | | Fix gtk2 build
* display: Remove zoom propertyPavel Grunt2016-02-151-24/+2
| | | | | It is possible to get the same info from the "zoom-level" property. virt_viewer_display_get_zoom() now returns TRUE if zoom level != 100
* display: Use common code to get preferred sizePavel Grunt2016-02-151-21/+31
|
* app: Compute monitor mapping only in fullscreenPavel Grunt2016-02-151-6/+20
|
* app: Do not show usbredir button without sessionPavel Grunt2016-02-151-4/+8
| | | | | | The button is visible in the fullscreen toolbar when waiting for a guest. Clicking on it causes the runtime warning: virt-viewer-CRITICAL **: virt_viewer_session_usb_device_selection: assertion 'VIRT_VIEWER_IS_SESSION(self)' failed
* app: Add comment only when config file has VM groupPavel Grunt2016-02-151-1/+1
| | | | | Avoid the debug message on close: virt-viewer-DEBUG: Unable to get comment from key file: Key file does not have group '39cd210d-5d45-478a-91fe-b3680307f2df'
* app: Return early on empty monitor mappingPavel Grunt2016-02-151-0/+5
| | | | | Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1304648
* display: Set value of desktop width and height property directlyPavel Grunt2016-02-031-6/+2
| | | | | | | | | | Avoid calling gtk_widget_queue_resize() and emiting the "display-desktop-resize" signal. The only user of the properties is virt_viewer_display_spice_set_desktop() which will call the function and emit the signal after setting both "desktop-width" and "desktop-height" properties. Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* display: Return early and remove a blockPavel Grunt2016-02-031-21/+18
| | | | Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* display: Remove unnecessary VIRT_VIEWER_DISPLAY castPavel Grunt2016-02-031-6/+6
| | | | Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* Remove GSLice usageFabiano Fidêncio2016-01-182-4/+4
| | | | | It's being slowly deprecated in glib https://bugzilla.gnome.org/show_bug.cgi?id=754687
* display: Set useful values for MIN_DISPLAY_{WIDTH, HEIGHT}Jonathon Jongsma2016-01-132-17/+20
| | | | | | | | | | | | | | | | | | | Nowadays the value for MIN_DISPLAY_{WIDTH,HEIGHT} is 50. This arbitrary value doesn't bring any benefit, doesn't provide a useful size for a desktop to be usable and can actually trigger some undefined behavior when reaching resolutions that are lower than the ones provided by the video drivers (as in rhbz#1296878). In order to avoid these issues and provide a minimum resolution that can still be useful for our users, let's use the same values for minimum width and height used by the linux QXL drivers (320x200). This also requires us to adjust the minimum requested widget size when zoom is enabled so that we don't accidentally request a size smaller than the driver can support. Related: rhbz#1296878 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
* display: set min value for desktop-{width,height} props as ↵Fabiano Fidêncio2016-01-081-2/+2
| | | | | | | | | | | | MIN_DISPLAY_{WIDTH,HEIGHT} Otherwise we can have warnings when resizing the virt-viewer window to the smallest possible size, like: (virt-viewer:11187): GLib-GObject-WARNING **: value "50" of type `gint' is invalid or out of range for property `desktop-height' of type `gint' Related: rhbz#1296878
* Refresh translations from zanataDaniel P. Berrange2015-12-0795-13510/+19069
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Update NEWS for release 3.0Daniel P. Berrange2015-12-031-0/+57
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Bump spice-gtk dep to 0.30.0 to avoid dep on git snapshot releaseDaniel P. Berrange2015-12-032-2/+2
|
* s/mingw62/mingw64/ in RPM spec fileDaniel P. Berrange2015-12-031-1/+1
|
* Avoid macro in RPM commentDaniel P. Berrange2015-12-031-1/+1
|
* autobuild: gtk2 has been dropped for windowsFabiano Fidêncio2015-12-011-34/+2
| | | | | | | 0a7fa73f is the commit that dropped support for gtk2 for the nsis installer. 03c014cb is the commit that dropped support for gtk2 for the msi installer.
* specs: add remote-viewer-connect.xmlFabiano Fidêncio2015-12-012-0/+3
| | | | | The file was introduced in commit 0571843d but never added to the spec files.
* nsis: add libbz2-1.dllFabiano Fidêncio2015-12-011-0/+2
| | | | mingw-bzip2 seems to be a mingw-freetype dependency.
* nsis: update nettle to 3.1.1Fabiano Fidêncio2015-12-011-4/+4
| | | | Use version 3.1.1, matching what currently is in f23.