diff options
author | Adam Young <ayoung@redhat.com> | 2011-11-10 22:12:52 -0500 |
---|---|---|
committer | Adam Young <ayoung@redhat.com> | 2011-12-06 11:20:03 -0500 |
commit | 6119a0222dee4953d51311489d8863daa62d9b14 (patch) | |
tree | dc30408d3be499e1f84c1c49d41bbc109731fb7a /pki/base/util/src/com/netscape | |
parent | 3c1a4af339dc1761b3a68abe9b0f26bd3cb389cf (diff) | |
download | pki-6119a0222dee4953d51311489d8863daa62d9b14.tar.gz pki-6119a0222dee4953d51311489d8863daa62d9b14.tar.xz pki-6119a0222dee4953d51311489d8863daa62d9b14.zip |
call statics statically
https://bugzilla.redhat.com/show_bug.cgi?id=728303
Updated with changes from code review
Leaving in the warning in GenericASN1Extension, ans that is an indication of a real problem, which will get addressed in a separate patch.
Diffstat (limited to 'pki/base/util/src/com/netscape')
-rw-r--r-- | pki/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java | 4 | ||||
-rw-r--r-- | pki/base/util/src/com/netscape/cmsutil/http/JssSSLSocketFactory.java | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/pki/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java b/pki/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java index 2cd13111..e659da9b 100644 --- a/pki/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java +++ b/pki/base/util/src/com/netscape/cmsutil/crypto/CryptoUtil.java @@ -661,10 +661,8 @@ public class CryptoUtil { CertificateSubjectName(new X500Name(subjname))); info.set(X509CertInfo.VALIDITY, new CertificateValidity(notBefore, notAfter)); - AlgorithmId sigAlgId = new AlgorithmId(); - info.set(X509CertInfo.ALGORITHM_ID, new - CertificateAlgorithmId(sigAlgId.get(alg))); + CertificateAlgorithmId(AlgorithmId.get(alg))); info.set(X509CertInfo.KEY, new CertificateX509Key(x509key)); info.set(X509CertInfo.EXTENSIONS, new CertificateExtensions()); return info; diff --git a/pki/base/util/src/com/netscape/cmsutil/http/JssSSLSocketFactory.java b/pki/base/util/src/com/netscape/cmsutil/http/JssSSLSocketFactory.java index ed4e9518..501886b5 100644 --- a/pki/base/util/src/com/netscape/cmsutil/http/JssSSLSocketFactory.java +++ b/pki/base/util/src/com/netscape/cmsutil/http/JssSSLSocketFactory.java @@ -121,7 +121,8 @@ public class JssSSLSocketFactory implements ISocketFactory { s.setUseClientMode(true); s.enableSSL2(false); - s.enableSSL2Default(false); + //TODO Do we rally want to set the default each time? + SSLSocket.enableSSL2Default(false); s.enableV2CompatibleHello(false); SSLHandshakeCompletedListener listener = null; |