diff options
author | Adam Young <ayoung@redhat.com> | 2011-12-07 11:02:06 -0500 |
---|---|---|
committer | Adam Young <ayoung@redhat.com> | 2011-12-20 20:39:09 -0500 |
commit | 1a37d6047e0db50d6809f716fc3035af1cb603fa (patch) | |
tree | 0ba12d3e5ea37d4b63a03e4df29b0fc37855dbff /pki/base/util/src/com/netscape | |
parent | 3425098266c4caebcf7dc58612ae5947e791c930 (diff) | |
download | pki-1a37d6047e0db50d6809f716fc3035af1cb603fa.tar.gz pki-1a37d6047e0db50d6809f716fc3035af1cb603fa.tar.xz pki-1a37d6047e0db50d6809f716fc3035af1cb603fa.zip |
Removal of unused private methods
These methods are uncallable.
There might be some discussion about the private default constructores. The Rules of Java are different from C++: If there is any constructor defined, all the other defaults befome uncallable. Thus, the private default constructors are not needed.
https://bugzilla.redhat.com/show_bug.cgi?id=728303
Conflicts:
pki/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
Diffstat (limited to 'pki/base/util/src/com/netscape')
8 files changed, 1 insertions, 33 deletions
diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/CertID.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/CertID.java index 29fbc4e8..3c563d93 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/CertID.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/CertID.java @@ -78,7 +78,6 @@ public class CertID implements ASN1Value /////////////////////////////////////////////////////////////////////// // Constructors /////////////////////////////////////////////////////////////////////// - private CertID() { } public CertID(AlgorithmIdentifier hashAlgorithm, OCTET_STRING issuerNameHash, OCTET_STRING issuerKeyHash, diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPRequest.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPRequest.java index 98f50e7e..ea2e5422 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPRequest.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPRequest.java @@ -65,11 +65,7 @@ public class OCSPRequest implements ASN1Value { return optionalSignature; } - - /////////////////////////////////////////////////////////////////////// - // Constructors - /////////////////////////////////////////////////////////////////////// - private OCSPRequest() { } + /* THIS code is probably broken. It does not properly encode the explicit element */ diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponse.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponse.java index 67f6242c..d8635fe2 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponse.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponse.java @@ -58,11 +58,6 @@ public class OCSPResponse implements ASN1Value return responseBytes; } - /////////////////////////////////////////////////////////////////////// - // Constructors - /////////////////////////////////////////////////////////////////////// - private OCSPResponse() { } - public OCSPResponse(OCSPResponseStatus responseStatus, ResponseBytes responseBytes) { diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponseStatus.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponseStatus.java index ee2b6202..145fbe7d 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponseStatus.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/OCSPResponseStatus.java @@ -69,11 +69,6 @@ public class OCSPResponseStatus implements ASN1Value return responseStatus.getValue(); } - /////////////////////////////////////////////////////////////////////// - // Constructors - /////////////////////////////////////////////////////////////////////// - private OCSPResponseStatus() { } - public OCSPResponseStatus(long val) { responseStatus = new ENUMERATED(val); diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/Request.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/Request.java index f180709d..9f277bb9 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/Request.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/Request.java @@ -72,11 +72,6 @@ public class Request implements ASN1Value return (Extension) singleRequestExtensions.elementAt(index); } - /////////////////////////////////////////////////////////////////////// - // constructors - /////////////////////////////////////////////////////////////////////// - private Request() { } - public Request(CertID reqCert, SEQUENCE singleRequestExtensions) { sequence = new SEQUENCE(); diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/ResponseBytes.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/ResponseBytes.java index 80a15b91..b5fed0d9 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/ResponseBytes.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/ResponseBytes.java @@ -64,11 +64,6 @@ public class ResponseBytes implements ASN1Value return response; } - /////////////////////////////////////////////////////////////////////// - // Constructors - /////////////////////////////////////////////////////////////////////// - private ResponseBytes() { } - public ResponseBytes(OBJECT_IDENTIFIER responseType, OCTET_STRING response) { sequence = new SEQUENCE(); diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/Signature.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/Signature.java index 2810182e..d670dfe2 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/Signature.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/Signature.java @@ -81,11 +81,6 @@ public class Signature implements ASN1Value return (Certificate) certs.elementAt(index); } - /////////////////////////////////////////////////////////////////////// - // constructors - /////////////////////////////////////////////////////////////////////// - private Signature() { } - public Signature(AlgorithmIdentifier signatureAlgorithm, BIT_STRING signature, SEQUENCE certs) { diff --git a/pki/base/util/src/com/netscape/cmsutil/ocsp/TBSRequest.java b/pki/base/util/src/com/netscape/cmsutil/ocsp/TBSRequest.java index 4e09c591..ea23200d 100644 --- a/pki/base/util/src/com/netscape/cmsutil/ocsp/TBSRequest.java +++ b/pki/base/util/src/com/netscape/cmsutil/ocsp/TBSRequest.java @@ -98,8 +98,6 @@ public class TBSRequest implements ASN1Value // constructors /////////////////////////////////////////////////////////////////////// - private TBSRequest() {} - public TBSRequest(INTEGER version, ANY requestorName, SEQUENCE requestList, SEQUENCE requestExtensions) { |