Remove needless string copying

More fat-trimming optimization for ~7% off listing syscall.*.

* dwflpp.cxx (dwflpp::iterate_over_functions): remove a parameter copy
  (dwflpp::module_name_matches): Use const string& parameters
  (dwflpp::name_has_wildcard): Ditto.
  (dwflpp::module_name_final_match): Ditto.
  (dwflpp::function_name_matches_pattern): Ditto.
  (dwflpp::function_name_matches): Ditto.
  (dwflpp::function_name_final_match): Ditto.

1 files changed, 6 insertions, 6 deletions

diff --git a/dwflpp.h b/dwflpp.h
index ec2fc2b9..b31efdf8 100644
--- a/dwflpp.h
+++ b/dwflpp.h
@@ -198,13 +198,13 @@ struct dwflpp
 
   Dwarf_Die *query_cu_containing_address(Dwarf_Addr a);
 
-  bool module_name_matches(std::string pattern);
-  bool name_has_wildcard(std::string pattern);
-  bool module_name_final_match(std::string pattern);
+  bool module_name_matches(const std::string& pattern);
+  bool name_has_wildcard(const std::string& pattern);
+  bool module_name_final_match(const std::string& pattern);
 
-  bool function_name_matches_pattern(std::string name, std::string pattern);
-  bool function_name_matches(std::string pattern);
-  bool function_name_final_match(std::string pattern);
+  bool function_name_matches_pattern(const std::string& name, const std::string& pattern);
+  bool function_name_matches(const std::string& pattern);
+  bool function_name_final_match(const std::string& pattern);
 
   void iterate_over_modules(int (* callback)(Dwfl_Module *, void **,
                                              const char *, Dwarf_Addr,