From 5f4c8c6ef761b6150d2d7d38fd601bec633f80f4 Mon Sep 17 00:00:00 2001 From: Josh Stone Date: Tue, 23 Jun 2009 18:31:38 -0700 Subject: Remove needless string copying More fat-trimming optimization for ~7% off listing syscall.*. * dwflpp.cxx (dwflpp::iterate_over_functions): remove a parameter copy (dwflpp::module_name_matches): Use const string& parameters (dwflpp::name_has_wildcard): Ditto. (dwflpp::module_name_final_match): Ditto. (dwflpp::function_name_matches_pattern): Ditto. (dwflpp::function_name_matches): Ditto. (dwflpp::function_name_final_match): Ditto. --- dwflpp.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'dwflpp.h') diff --git a/dwflpp.h b/dwflpp.h index ec2fc2b9..b31efdf8 100644 --- a/dwflpp.h +++ b/dwflpp.h @@ -198,13 +198,13 @@ struct dwflpp Dwarf_Die *query_cu_containing_address(Dwarf_Addr a); - bool module_name_matches(std::string pattern); - bool name_has_wildcard(std::string pattern); - bool module_name_final_match(std::string pattern); + bool module_name_matches(const std::string& pattern); + bool name_has_wildcard(const std::string& pattern); + bool module_name_final_match(const std::string& pattern); - bool function_name_matches_pattern(std::string name, std::string pattern); - bool function_name_matches(std::string pattern); - bool function_name_final_match(std::string pattern); + bool function_name_matches_pattern(const std::string& name, const std::string& pattern); + bool function_name_matches(const std::string& pattern); + bool function_name_final_match(const std::string& pattern); void iterate_over_modules(int (* callback)(Dwfl_Module *, void **, const char *, Dwarf_Addr, -- cgit