diff options
author | Jakub Hrozek <jhrozek@redhat.com> | 2012-09-12 19:23:48 +0200 |
---|---|---|
committer | Jakub Hrozek <jhrozek@redhat.com> | 2012-09-13 16:51:38 +0200 |
commit | d25e7c659361ebd794ef011dc9305543f266e8c4 (patch) | |
tree | 7203927b13d500ce1b41c12db712625bfe6f5f15 /src/providers/fail_over.c | |
parent | 3c79852d5d5ba4111c0535bafea43450dba8ed12 (diff) | |
download | sssd-d25e7c659361ebd794ef011dc9305543f266e8c4.tar.gz sssd-d25e7c659361ebd794ef011dc9305543f266e8c4.tar.xz sssd-d25e7c659361ebd794ef011dc9305543f266e8c4.zip |
FO: Check server validity before setting status
The list of resolved servers is allocated on the back end context and
kept in the fo_service structure. However, a single request often
resolves a server and keeps a pointer until the end of a request and
only then gives feedback about the server based on the request result.
This presents a big race condition in case the SRV resolution is used.
When there are requests coming in in parallel, it is possible that an
incoming request will invalidate a server until another request that
holds a pointer to the original server is able to give a feedback.
This patch simply checks if a server is in the list of servers
maintained by a service before reading its status.
https://fedorahosted.org/sssd/ticket/1364
Diffstat (limited to 'src/providers/fail_over.c')
-rw-r--r-- | src/providers/fail_over.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/providers/fail_over.c b/src/providers/fail_over.c index 422cd675..d776037a 100644 --- a/src/providers/fail_over.c +++ b/src/providers/fail_over.c @@ -1564,10 +1564,13 @@ void fo_reset_services(struct fo_ctx *fo_ctx) } } -struct fo_service * -fo_get_server_service(struct fo_server *server) +bool fo_svc_has_server(struct fo_service *service, struct fo_server *server) { - if (!server) return NULL; - return server->service; -} + struct fo_server *srv; + + DLIST_FOR_EACH(srv, service->server_list) { + if (srv == server) return true; + } + return false; +} |