diff options
| author | Zhongyue Luo <zhongyue.nah@intel.com> | 2013-05-10 23:15:08 +0800 |
|---|---|---|
| committer | Zhongyue Luo <zhongyue.nah@intel.com> | 2013-05-13 18:15:10 +0800 |
| commit | a51469326e84ed977ecc4e57fd3d46cdc21aa08f (patch) | |
| tree | a22f42c9bf362d06f43efd618579345f74a785cf /openstack/common/rpc | |
| parent | 20379f2816774469287502cf857dc01a93ad1370 (diff) | |
| download | oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.tar.gz oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.tar.xz oslo-a51469326e84ed977ecc4e57fd3d46cdc21aa08f.zip | |
Removes len() on empty sequence evaluation
PEP8 suggestes, "For sequences, use the fact that empty sequences are false."
Change-Id: I4c600a7a6230a55328ee46f7c59f340f37abc18f
Diffstat (limited to 'openstack/common/rpc')
| -rw-r--r-- | openstack/common/rpc/impl_zmq.py | 4 | ||||
| -rw-r--r-- | openstack/common/rpc/matchmaker.py | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/openstack/common/rpc/impl_zmq.py b/openstack/common/rpc/impl_zmq.py index 7a5d814..fec299c 100644 --- a/openstack/common/rpc/impl_zmq.py +++ b/openstack/common/rpc/impl_zmq.py @@ -180,7 +180,7 @@ class ZmqSocket(object): return # We must unsubscribe, or we'll leak descriptors. - if len(self.subscriptions) > 0: + if self.subscriptions: for f in self.subscriptions: try: self.sock.setsockopt(zmq.UNSUBSCRIBE, f) @@ -763,7 +763,7 @@ def _multi_send(method, context, topic, msg, timeout=None, LOG.debug(_("Sending message(s) to: %s"), queues) # Don't stack if we have no matchmaker results - if len(queues) == 0: + if not queues: LOG.warn(_("No matchmaker results. Not casting.")) # While not strictly a timeout, callers know how to handle # this exception and a timeout isn't too big a lie. diff --git a/openstack/common/rpc/matchmaker.py b/openstack/common/rpc/matchmaker.py index 7366246..3d72ae7 100644 --- a/openstack/common/rpc/matchmaker.py +++ b/openstack/common/rpc/matchmaker.py @@ -245,7 +245,7 @@ class HeartbeatMatchMakerBase(MatchMakerBase): yielding for CONF.matchmaker_heartbeat_freq seconds between iterations. """ - if len(self.hosts) == 0: + if not self.hosts: raise MatchMakerException( _("Register before starting heartbeat.")) |