From a51469326e84ed977ecc4e57fd3d46cdc21aa08f Mon Sep 17 00:00:00 2001 From: Zhongyue Luo Date: Fri, 10 May 2013 23:15:08 +0800 Subject: Removes len() on empty sequence evaluation PEP8 suggestes, "For sequences, use the fact that empty sequences are false." Change-Id: I4c600a7a6230a55328ee46f7c59f340f37abc18f --- openstack/common/rpc/impl_zmq.py | 4 ++-- openstack/common/rpc/matchmaker.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'openstack/common/rpc') diff --git a/openstack/common/rpc/impl_zmq.py b/openstack/common/rpc/impl_zmq.py index 7a5d814..fec299c 100644 --- a/openstack/common/rpc/impl_zmq.py +++ b/openstack/common/rpc/impl_zmq.py @@ -180,7 +180,7 @@ class ZmqSocket(object): return # We must unsubscribe, or we'll leak descriptors. - if len(self.subscriptions) > 0: + if self.subscriptions: for f in self.subscriptions: try: self.sock.setsockopt(zmq.UNSUBSCRIBE, f) @@ -763,7 +763,7 @@ def _multi_send(method, context, topic, msg, timeout=None, LOG.debug(_("Sending message(s) to: %s"), queues) # Don't stack if we have no matchmaker results - if len(queues) == 0: + if not queues: LOG.warn(_("No matchmaker results. Not casting.")) # While not strictly a timeout, callers know how to handle # this exception and a timeout isn't too big a lie. diff --git a/openstack/common/rpc/matchmaker.py b/openstack/common/rpc/matchmaker.py index 7366246..3d72ae7 100644 --- a/openstack/common/rpc/matchmaker.py +++ b/openstack/common/rpc/matchmaker.py @@ -245,7 +245,7 @@ class HeartbeatMatchMakerBase(MatchMakerBase): yielding for CONF.matchmaker_heartbeat_freq seconds between iterations. """ - if len(self.hosts) == 0: + if not self.hosts: raise MatchMakerException( _("Register before starting heartbeat.")) -- cgit