diff options
| author | Jeff Layton <jlayton@primarydata.com> | 2014-09-12 13:20:13 -0400 |
|---|---|---|
| committer | Steve Dickson <steved@redhat.com> | 2014-09-15 13:56:57 -0400 |
| commit | 8399548e6b904116e0e41d83e4a4b571af8ea578 (patch) | |
| tree | defc32c82097a91c780fd897815a373a594323bc | |
| parent | d89e3fc7d3b14dea481bd9af0bca996ced689bf6 (diff) | |
| download | nfs-utils-8399548e6b904116e0e41d83e4a4b571af8ea578.tar.gz nfs-utils-8399548e6b904116e0e41d83e4a4b571af8ea578.tar.xz nfs-utils-8399548e6b904116e0e41d83e4a4b571af8ea578.zip | |
gssd: ensure that preferred_realm is non-NULL before passing it to strcmp
It's possible for "preferred_realm" to be NULL, in which case we
don't want to pass it to strcmp. Other places that use this variable
test whether it's NULL first -- we need to do the same here.
This should fix the gssd crash reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=1108615
Reported-by: Brian J. Murrell <brian@interlinx.bc.ca>
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
| -rw-r--r-- | utils/gssd/krb5_util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index 8369fdf..f1ebc0d 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -876,7 +876,7 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *tgtname, i = 0; realm = realmnames[i]; - if (strcmp (realm, preferred_realm) != 0) { + if (preferred_realm && strcmp (realm, preferred_realm) != 0) { realm = preferred_realm; /* resetting the realmnames index */ i = -1; |