From 8399548e6b904116e0e41d83e4a4b571af8ea578 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Fri, 12 Sep 2014 13:20:13 -0400 Subject: gssd: ensure that preferred_realm is non-NULL before passing it to strcmp It's possible for "preferred_realm" to be NULL, in which case we don't want to pass it to strcmp. Other places that use this variable test whether it's NULL first -- we need to do the same here. This should fix the gssd crash reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1108615 Reported-by: Brian J. Murrell Signed-off-by: Jeff Layton Signed-off-by: Steve Dickson --- utils/gssd/krb5_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index 8369fdf..f1ebc0d 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -876,7 +876,7 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *tgtname, i = 0; realm = realmnames[i]; - if (strcmp (realm, preferred_realm) != 0) { + if (preferred_realm && strcmp (realm, preferred_realm) != 0) { realm = preferred_realm; /* resetting the realmnames index */ i = -1; -- cgit