summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederic Peters <fpeters@entrouvert.com>2006-03-04 12:35:37 +0000
committerFrederic Peters <fpeters@entrouvert.com>2006-03-04 12:35:37 +0000
commit3f5def3f97d8b42aeff23eb3a6f47341b57ee38f (patch)
tree3504ebad56338bad10c64c27f046141bbc2737ef
parent676ed285420c158b0068fc846578d80b9d5e79b7 (diff)
downloadlasso-3f5def3f97d8b42aeff23eb3a6f47341b57ee38f.tar.gz
lasso-3f5def3f97d8b42aeff23eb3a6f47341b57ee38f.tar.xz
lasso-3f5def3f97d8b42aeff23eb3a6f47341b57ee38f.zip
added comment about why not to use memset
-rw-r--r--lasso/id-ff/server.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lasso/id-ff/server.c b/lasso/id-ff/server.c
index 24c8bc03..77276916 100644
--- a/lasso/id-ff/server.c
+++ b/lasso/id-ff/server.c
@@ -386,10 +386,12 @@ finalize(GObject *object)
g_free(server->private_key);
if (server->private_key_password) {
+ /* don't use memset() because it may be optimised away by
+ * compiler (since the string is freeed just after */
while (server->private_key_password[i])
server->private_key_password[i++] = 0;
+ g_free(server->private_key_password);
}
- g_free(server->private_key_password);
g_free(server->certificate);
g_free(server->private_data);