From 3f5def3f97d8b42aeff23eb3a6f47341b57ee38f Mon Sep 17 00:00:00 2001 From: Frederic Peters Date: Sat, 4 Mar 2006 12:35:37 +0000 Subject: added comment about why not to use memset --- lasso/id-ff/server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lasso/id-ff/server.c b/lasso/id-ff/server.c index 24c8bc03..77276916 100644 --- a/lasso/id-ff/server.c +++ b/lasso/id-ff/server.c @@ -386,10 +386,12 @@ finalize(GObject *object) g_free(server->private_key); if (server->private_key_password) { + /* don't use memset() because it may be optimised away by + * compiler (since the string is freeed just after */ while (server->private_key_password[i]) server->private_key_password[i++] = 0; + g_free(server->private_key_password); } - g_free(server->private_key_password); g_free(server->certificate); g_free(server->private_data); -- cgit