summaryrefslogtreecommitdiffstats
path: root/ipaplatform
diff options
context:
space:
mode:
authorJan Barta <55042barta@sstebrno.eu>2016-06-02 09:58:52 +0200
committerMartin Basti <mbasti@redhat.com>2016-09-22 16:52:57 +0200
commit36484e8672f5ee1fdc2bd57622e330ab8dbb7671 (patch)
tree1f06a3e4aebbc0e6e7fe28e15c9e677e396932a3 /ipaplatform
parent929086e0992cc32a654b4dfa435f536ecb0c665b (diff)
downloadfreeipa-36484e8672f5ee1fdc2bd57622e330ab8dbb7671.tar.gz
freeipa-36484e8672f5ee1fdc2bd57622e330ab8dbb7671.tar.xz
freeipa-36484e8672f5ee1fdc2bd57622e330ab8dbb7671.zip
pylint: fix simplifiable-if-statement warnings
fix inefficient if statements, enable pylint check Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Diffstat (limited to 'ipaplatform')
-rw-r--r--ipaplatform/base/services.py12
1 files changed, 4 insertions, 8 deletions
diff --git a/ipaplatform/base/services.py b/ipaplatform/base/services.py
index a36b2f4ff..750d97953 100644
--- a/ipaplatform/base/services.py
+++ b/ipaplatform/base/services.py
@@ -271,10 +271,8 @@ class SystemdService(PlatformService):
ipautil.run(args, skip_output=not capture_output)
- if getattr(self.api.env, 'context', None) in ['ipactl', 'installer']:
- update_service_list = True
- else:
- update_service_list = False
+ update_service_list = getattr(self.api.env, 'context',
+ None) in ['ipactl', 'installer']
super(SystemdService, self).stop(
instance_name,
update_service_list=update_service_list)
@@ -284,10 +282,8 @@ class SystemdService(PlatformService):
self.service_instance(instance_name)],
skip_output=not capture_output)
- if getattr(self.api.env, 'context', None) in ['ipactl', 'installer']:
- update_service_list = True
- else:
- update_service_list = False
+ update_service_list = getattr(self.api.env, 'context',
+ None) in ['ipactl', 'installer']
if wait and self.is_running(instance_name):
self.wait_for_open_ports(self.service_instance(instance_name))