From 36484e8672f5ee1fdc2bd57622e330ab8dbb7671 Mon Sep 17 00:00:00 2001 From: Jan Barta <55042barta@sstebrno.eu> Date: Thu, 2 Jun 2016 09:58:52 +0200 Subject: pylint: fix simplifiable-if-statement warnings fix inefficient if statements, enable pylint check Reviewed-By: Tomas Krizek Reviewed-By: Florence Blanc-Renaud --- ipaplatform/base/services.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'ipaplatform') diff --git a/ipaplatform/base/services.py b/ipaplatform/base/services.py index a36b2f4ff..750d97953 100644 --- a/ipaplatform/base/services.py +++ b/ipaplatform/base/services.py @@ -271,10 +271,8 @@ class SystemdService(PlatformService): ipautil.run(args, skip_output=not capture_output) - if getattr(self.api.env, 'context', None) in ['ipactl', 'installer']: - update_service_list = True - else: - update_service_list = False + update_service_list = getattr(self.api.env, 'context', + None) in ['ipactl', 'installer'] super(SystemdService, self).stop( instance_name, update_service_list=update_service_list) @@ -284,10 +282,8 @@ class SystemdService(PlatformService): self.service_instance(instance_name)], skip_output=not capture_output) - if getattr(self.api.env, 'context', None) in ['ipactl', 'installer']: - update_service_list = True - else: - update_service_list = False + update_service_list = getattr(self.api.env, 'context', + None) in ['ipactl', 'installer'] if wait and self.is_running(instance_name): self.wait_for_open_ports(self.service_instance(instance_name)) -- cgit