diff options
| author | Andrew Tridgell <tridge@samba.org> | 2006-09-16 16:59:37 +0000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2006-09-16 16:59:37 +0000 |
| commit | 638ece0f51a1f23a40ac205e7a0148119a55e938 (patch) | |
| tree | 50cda47dc715fd1ebb0fd0c1b8557286e6f6a6d9 /source/lib/registry/tools/regdiff.c | |
| parent | d0215a51f1855697ec25e29d8051d351806076e0 (diff) | |
| download | samba-638ece0f51a1f23a40ac205e7a0148119a55e938.tar.gz samba-638ece0f51a1f23a40ac205e7a0148119a55e938.tar.xz samba-638ece0f51a1f23a40ac205e7a0148119a55e938.zip | |
r18584: found one of the fd leaks. The registry backend was using a
talloc(NULL, xxx) to allocate the registry context. That had two
consequences
1) it was a massive memory leak, as all winreg operations leaked their
entire context (including an open ldb database) every time
2) event_context_find() never found the exsting event context, so we
used a new event context each time, which called epoll_create()
each time, which caused a fd to be allocated
Diffstat (limited to 'source/lib/registry/tools/regdiff.c')
| -rw-r--r-- | source/lib/registry/tools/regdiff.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/lib/registry/tools/regdiff.c b/source/lib/registry/tools/regdiff.c index dbbe555ad69..b8bf654a6b7 100644 --- a/source/lib/registry/tools/regdiff.c +++ b/source/lib/registry/tools/regdiff.c @@ -54,8 +54,8 @@ int main(int argc, char **argv) error = WERR_OK; switch(opt) { case 'L': - if (!h1 && !from_null) error = reg_open_local(&h1, NULL, cmdline_credentials); - else if (!h2) error = reg_open_local(&h2, NULL, cmdline_credentials); + if (!h1 && !from_null) error = reg_open_local(NULL, &h1, NULL, cmdline_credentials); + else if (!h2) error = reg_open_local(NULL, &h2, NULL, cmdline_credentials); break; case 'R': if (!h1 && !from_null) |