r18584: found one of the fd leaks. The registry backend was using a

talloc(NULL, xxx) to allocate the registry context. That had two
consequences

1) it was a massive memory leak, as all winreg operations leaked their
   entire context (including an open ldb database) every time

2) event_context_find() never found the exsting event context, so we
   used a new event context each time, which called epoll_create()
   each time, which caused a fd to be allocated

5 files changed, 10 insertions, 7 deletions

diff --git a/source/lib/registry/reg_samba.c b/source/lib/registry/reg_samba.c
index 4a88d96042f..3553c4cb6d1 100644
--- a/source/lib/registry/reg_samba.c
+++ b/source/lib/registry/reg_samba.c
@@ -68,9 +68,12 @@ static WERROR reg_samba_get_predef (struct registry_context *ctx, uint32_t hkey,
 	return error;
 }
 
-_PUBLIC_ WERROR reg_open_local (struct registry_context **ctx, struct auth_session_info *session_info, struct cli_credentials *credentials)
+_PUBLIC_ WERROR reg_open_local (TALLOC_CTX *mem_ctx, 
+				struct registry_context **ctx, 
+				struct auth_session_info *session_info, 
+				struct cli_credentials *credentials)
 {
-	*ctx = talloc(NULL, struct registry_context);
+	*ctx = talloc(mem_ctx, struct registry_context);
 	(*ctx)->credentials = talloc_reference(*ctx, credentials);
 	(*ctx)->session_info = talloc_reference(*ctx, session_info);
 	(*ctx)->get_predefined_key = reg_samba_get_predef;
diff --git a/source/lib/registry/tools/regdiff.c b/source/lib/registry/tools/regdiff.c
index dbbe555ad69..b8bf654a6b7 100644
--- a/source/lib/registry/tools/regdiff.c
+++ b/source/lib/registry/tools/regdiff.c
@@ -54,8 +54,8 @@ int main(int argc, char **argv)
 		error = WERR_OK;
 		switch(opt)	{
 		case 'L':
-			if (!h1 && !from_null) error = reg_open_local(&h1, NULL, cmdline_credentials);
-			else if (!h2) error = reg_open_local(&h2, NULL, cmdline_credentials);
+			if (!h1 && !from_null) error = reg_open_local(NULL, &h1, NULL, cmdline_credentials);
+			else if (!h2) error = reg_open_local(NULL, &h2, NULL, cmdline_credentials);
 			break;
 		case 'R':
 			if (!h1 && !from_null) 
diff --git a/source/lib/registry/tools/regpatch.c b/source/lib/registry/tools/regpatch.c
index 7ed246566cb..42cdac860be 100644
--- a/source/lib/registry/tools/regpatch.c
+++ b/source/lib/registry/tools/regpatch.c
@@ -52,7 +52,7 @@ int main(int argc, char **argv)
 	if (remote) {
 		error = reg_open_remote (&h, NULL, cmdline_credentials, remote, NULL);
 	} else {
-		error = reg_open_local (&h, NULL, cmdline_credentials);
+		error = reg_open_local (NULL, &h, NULL, cmdline_credentials);
 	}
 
 	if (W_ERROR_IS_OK(error)) {
diff --git a/source/lib/registry/tools/regshell.c b/source/lib/registry/tools/regshell.c
index 0bc1cfe3242..8436a3f505e 100644
--- a/source/lib/registry/tools/regshell.c
+++ b/source/lib/registry/tools/regshell.c
@@ -434,7 +434,7 @@ static char **reg_completion(const char *text, int start, int end)
 	} else if (backend) {
 		error = reg_open_hive(NULL, backend, poptGetArg(pc), NULL, cmdline_credentials, &curkey);
 	} else {
-		error = reg_open_local(&h, NULL, cmdline_credentials);
+		error = reg_open_local(NULL, &h, NULL, cmdline_credentials);
 	}
 
 	if(!W_ERROR_IS_OK(error)) {
diff --git a/source/lib/registry/tools/regtree.c b/source/lib/registry/tools/regtree.c
index 31f5a89a1b6..6b3c20eae3c 100644
--- a/source/lib/registry/tools/regtree.c
+++ b/source/lib/registry/tools/regtree.c
@@ -122,7 +122,7 @@ int main(int argc, char **argv)
 			return 1;
 		}
 	} else {
-		error = reg_open_local (&h, NULL, cmdline_credentials);
+		error = reg_open_local (NULL, &h, NULL, cmdline_credentials);
 
 		if(!W_ERROR_IS_OK(error)) {
 			fprintf(stderr, "Unable to open local registry:%s \n", win_errstr(error));