diff options
author | Garming Sam <garming@catalyst.net.nz> | 2014-01-03 11:14:13 +1300 |
---|---|---|
committer | Kamen Mazdrashki <kamenim@samba.org> | 2014-02-10 02:26:28 +0100 |
commit | 9f2e6f532d085d864f44351e99212a63bc6a66ee (patch) | |
tree | 38acb8eba6962957cac5ded3cca9d52f682fd923 /python | |
parent | a3979677a825765b70e55720cf19a40e0a3b33af (diff) | |
download | samba-9f2e6f532d085d864f44351e99212a63bc6a66ee.tar.gz samba-9f2e6f532d085d864f44351e99212a63bc6a66ee.tar.xz samba-9f2e6f532d085d864f44351e99212a63bc6a66ee.zip |
s4:samba-tool/testparm: add a warning when acting as an AD-DC and not using UTF-8
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-User(master): Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date(master): Mon Feb 10 02:26:28 CET 2014 on sn-devel-104
Diffstat (limited to 'python')
-rw-r--r-- | python/samba/netcmd/testparm.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py index 7825d259fb5..9af141d3907 100644 --- a/python/samba/netcmd/testparm.py +++ b/python/samba/netcmd/testparm.py @@ -156,6 +156,14 @@ class cmd_testparm(Command): "membership.") valid = False + role = lp.get("server role") + charset = lp.get("unix charset").upper() + + if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]: + logger.warning( + "When acting as Active Directory domain controller, " + "unix charset is expected to be UTF-8.") + return valid def allow_access(self, deny_list, allow_list, cname, caddr): |