From 9f2e6f532d085d864f44351e99212a63bc6a66ee Mon Sep 17 00:00:00 2001 From: Garming Sam Date: Fri, 3 Jan 2014 11:14:13 +1300 Subject: s4:samba-tool/testparm: add a warning when acting as an AD-DC and not using UTF-8 Signed-off-by: Garming Sam Signed-off-by: Andrew Bartlett Reviewed-by: Andrew Bartlett Reviewed-by: Kamen Mazdrashki Autobuild-User(master): Kamen Mazdrashki Autobuild-Date(master): Mon Feb 10 02:26:28 CET 2014 on sn-devel-104 --- python/samba/netcmd/testparm.py | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'python') diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py index 7825d259fb5..9af141d3907 100644 --- a/python/samba/netcmd/testparm.py +++ b/python/samba/netcmd/testparm.py @@ -156,6 +156,14 @@ class cmd_testparm(Command): "membership.") valid = False + role = lp.get("server role") + charset = lp.get("unix charset").upper() + + if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]: + logger.warning( + "When acting as Active Directory domain controller, " + "unix charset is expected to be UTF-8.") + return valid def allow_access(self, deny_list, allow_list, cname, caddr): -- cgit