summaryrefslogtreecommitdiffstats
path: root/lib/puppet/parser/functions
diff options
context:
space:
mode:
authorMarkus Roberts <Markus@reality.com>2010-07-23 08:47:48 -0700
committerMarkus Roberts <Markus@reality.com>2010-07-25 22:24:34 -0700
commit1d494a3104e9794cc09ba27c701ced68a74fa398 (patch)
tree40305914cbd9dacd8faa7f2e59c7ce755175f530 /lib/puppet/parser/functions
parent23830504dfeb48b2d162e44b84b6f9dfa97e4e7e (diff)
downloadpuppet-1d494a3104e9794cc09ba27c701ced68a74fa398.tar.gz
puppet-1d494a3104e9794cc09ba27c701ced68a74fa398.tar.xz
puppet-1d494a3104e9794cc09ba27c701ced68a74fa398.zip
Tweak to fix for #4302--dangling ref to known_resource_types
Since we were clearing the thread variable containing the compiler's reference to it's environment's known resource types at the start of each compile the reference remaining at the end of a compilation could never be used and was thus just garbage that we were arbitrarily retaining. This patch moves the clearing of the thread var to the _end_ of compilation so that it's always nil except in the middle of a compile. This raises an interesting question; should the ref just live on the compiler object and we could dispense with the thread-var? It might require things that now only know about the environment to need a ref to the compiler and introduce other thread issues (e.g. we might just end up needing a :current_compiler thread variable, for no net gain in simplicity).
Diffstat (limited to 'lib/puppet/parser/functions')
0 files changed, 0 insertions, 0 deletions