diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2011-12-05 13:39:30 +0100 |
|---|---|---|
| committer | Endi S. Dewata <edewata@redhat.com> | 2011-12-05 16:02:11 +0000 |
| commit | 1ffbec9942ad90e00e28b05296d3233f52ce2dad (patch) | |
| tree | db2226435f5a925a8073f482e626565c3d2e4375 /install/ui/dialog.js | |
| parent | c5ca34f41d2aede667c19d2213a5d7e79a5e301c (diff) | |
| download | freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.tar.gz freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.tar.xz freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.zip | |
Removed usage of bitwise assignment operators in logical operations
JavaScript &= and |= are bitwise operators. They are shortened version of:
foo = foo & bar
foo = foo | bar
In some places they were used as shortened version of logical operation and assignment.
foo = foo && bar
It lead to type conversion to Number which is wrong (0 !== false).
This patch replaces such occurances with full version of logical operation and asignment.
https://fedorahosted.org/freeipa/ticket/2040
Diffstat (limited to 'install/ui/dialog.js')
| -rw-r--r-- | install/ui/dialog.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/install/ui/dialog.js b/install/ui/dialog.js index 44bd11cc..375ab84c 100644 --- a/install/ui/dialog.js +++ b/install/ui/dialog.js @@ -99,7 +99,7 @@ IPA.dialog = function(spec) { var fields = that.fields.get_fields(); for (var i=0; i<fields.length; i++) { var field = fields[i]; - valid &= field.validate() && field.validate_required(); + valid = field.validate() && field.validate_required() && valid; } return valid; }; |