From 1ffbec9942ad90e00e28b05296d3233f52ce2dad Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvoborni@redhat.com>
Date: Mon, 5 Dec 2011 13:39:30 +0100
Subject: Removed usage of bitwise assignment operators in logical operations

JavaScript &= and |= are bitwise operators. They are shortened version of:
 foo = foo & bar
 foo = foo | bar

In some places they were used as shortened version of logical operation and assignment.
 foo = foo && bar

It lead to type conversion to Number which is wrong (0 !== false).

This patch replaces such occurances with full version of logical operation and asignment.

https://fedorahosted.org/freeipa/ticket/2040
---
 install/ui/dialog.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'install/ui/dialog.js')

diff --git a/install/ui/dialog.js b/install/ui/dialog.js
index 44bd11cc..375ab84c 100644
--- a/install/ui/dialog.js
+++ b/install/ui/dialog.js
@@ -99,7 +99,7 @@ IPA.dialog = function(spec) {
         var fields = that.fields.get_fields();
         for (var i=0; i<fields.length; i++) {
             var field = fields[i];
-            valid &= field.validate() && field.validate_required();
+            valid = field.validate() && field.validate_required() && valid;
         }
         return valid;
     };
-- 
cgit