diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-09-15 16:05:30 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-02-11 20:38:42 +0100 |
| commit | 5085d263f2f084778b1314fc5e808668c3758d82 (patch) | |
| tree | da7a12dd45222166481c225963bfedca23aaa115 /src/python | |
| parent | 5594736ea2618bb3e487f47fd199e1d2cf4c58fd (diff) | |
| download | sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.gz sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.xz sssd-5085d263f2f084778b1314fc5e808668c3758d82.zip | |
Fix warning: equality comparison with extraneous parentheses
Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: remove extraneous parentheses around the comparison
to silence this warning
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~ ^ ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: use '=' to turn this equality comparison into an assignment
if (((wbc_status) == WBC_ERR_SUCCESS)) {
^~
=
The reason is definition of some macros which were used in if conditions.
Reviewed-by: Michal Židek <mzidek@redhat.com>
Diffstat (limited to 'src/python')
| -rw-r--r-- | src/python/pyhbac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/python/pyhbac.c b/src/python/pyhbac.c index c46f7c6b3..f3aaa60f0 100644 --- a/src/python/pyhbac.c +++ b/src/python/pyhbac.c @@ -794,7 +794,7 @@ hbac_rule_set_enabled(HbacRuleObject *self, PyObject *enabled, void *closure) Py_DECREF(utf8_str); return 0; - } else if (PyBool_Check(enabled)) { + } else if (PyBool_Check(enabled) == true) { self->enabled = (enabled == Py_True); return 0; } else if (PYNUMBER_CHECK(enabled)) { |