Make PAM responses more compatible with D-BUS spec

Previously, the PAM responses could contain an arbitrary number of
arguments. This is not acceptable by the D-BUS protocol, as there
is no way to introspect it. This patch converts the response
objects to be an array of D-BUS structs.

It also fixes two potential memory leaks by not unref'ing the
reply object if we get an error.

1 files changed, 2 insertions, 0 deletions

diff --git a/server/providers/data_provider_be.c b/server/providers/data_provider_be.c
index 15afa55ae..93cae0702 100644
--- a/server/providers/data_provider_be.c
+++ b/server/providers/data_provider_be.c
@@ -487,6 +487,7 @@ static void be_pam_handler_callback(struct be_req *req,
     dbret = dp_pack_pam_response(reply, pd);
     if (!dbret) {
         DEBUG(1, ("Failed to generate dbus reply\n"));
+        dbus_message_unref(reply);
         return;
     }
 
@@ -614,6 +615,7 @@ done:
     if (!ret) {
         DEBUG(1, ("Failed to generate dbus reply\n"));
         talloc_free(be_req);
+        dbus_message_unref(reply);
         return EIO;
     }