diff options
| author | ocean <ocean@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2005-12-19 02:42:33 +0000 |
|---|---|---|
| committer | ocean <ocean@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2005-12-19 02:42:33 +0000 |
| commit | af740cbea7486b878cab875de9c917db69a72e53 (patch) | |
| tree | e75e97b01282d1d7d4f638540689bbf7c2c1ad8a /ChangeLog | |
| parent | ddc5114c139dfdb2fa091c4d33bd6a8e1caccf6f (diff) | |
| download | ruby-af740cbea7486b878cab875de9c917db69a72e53.tar.gz ruby-af740cbea7486b878cab875de9c917db69a72e53.tar.xz ruby-af740cbea7486b878cab875de9c917db69a72e53.zip | |
* ext/syck/rubyext.c: sorry, I reverted my "should set newly
allocated memory instead of RString's internal storage" stuff.
node allocated in rubyext.c seems to be freed by rb_syck_free_node
not syck_free_node, and it won't free data.str->ptr and type_id.
(I still think this is unsafe because RString(foo)->ptr becomes
dangling pointer when RString is modified or freed, but anyway
I misunderstood, so go back to original code for now)
git-svn-id: http://svn.ruby-lang.org/repos/ruby/trunk@9708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 11 |
1 files changed, 11 insertions, 0 deletions
@@ -1,3 +1,14 @@ +Mon Dec 19 11:37:47 2005 Hirokazu Yamamoto <ocean@m2.ccsnet.ne.jp> + + * ext/syck/rubyext.c: sorry, I reverted my "should set newly + allocated memory instead of RString's internal storage" stuff. + node allocated in rubyext.c seems to be freed by rb_syck_free_node + not syck_free_node, and it won't free data.str->ptr and type_id. + + (I still think this is unsafe because RString(foo)->ptr becomes + dangling pointer when RString is modified or freed, but anyway + I misunderstood, so go back to original code for now) + Sat Dec 17 21:50:41 2005 Hirokazu Yamamoto <ocean@m2.ccsnet.ne.jp> * ext/syck/rubyext.c (syck_emitter_reset): should initialize |