From af740cbea7486b878cab875de9c917db69a72e53 Mon Sep 17 00:00:00 2001 From: ocean Date: Mon, 19 Dec 2005 02:42:33 +0000 Subject: * ext/syck/rubyext.c: sorry, I reverted my "should set newly allocated memory instead of RString's internal storage" stuff. node allocated in rubyext.c seems to be freed by rb_syck_free_node not syck_free_node, and it won't free data.str->ptr and type_id. (I still think this is unsafe because RString(foo)->ptr becomes dangling pointer when RString is modified or freed, but anyway I misunderstood, so go back to original code for now) git-svn-id: http://svn.ruby-lang.org/repos/ruby/trunk@9708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 071b0007d..41513920d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +Mon Dec 19 11:37:47 2005 Hirokazu Yamamoto + + * ext/syck/rubyext.c: sorry, I reverted my "should set newly + allocated memory instead of RString's internal storage" stuff. + node allocated in rubyext.c seems to be freed by rb_syck_free_node + not syck_free_node, and it won't free data.str->ptr and type_id. + + (I still think this is unsafe because RString(foo)->ptr becomes + dangling pointer when RString is modified or freed, but anyway + I misunderstood, so go back to original code for now) + Sat Dec 17 21:50:41 2005 Hirokazu Yamamoto * ext/syck/rubyext.c (syck_emitter_reset): should initialize -- cgit