diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-04 15:58:31 +0000 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2012-03-04 15:58:31 +0000 |
| commit | 98c92abf4ef5b91638c0c3589b66b88de6b4dc70 (patch) | |
| tree | 409d1f9a2d7c595c8b029f7999cefe64d2e2954c /tools/toollib.c | |
| parent | 01c62d8f9dec6fe0e43ba9b39742a218aed702bf (diff) | |
| download | lvm2-98c92abf4ef5b91638c0c3589b66b88de6b4dc70.tar.gz lvm2-98c92abf4ef5b91638c0c3589b66b88de6b4dc70.tar.xz lvm2-98c92abf4ef5b91638c0c3589b66b88de6b4dc70.zip | |
Add FIXMEs
Processing loop needs some thinking
Diffstat (limited to 'tools/toollib.c')
| -rw-r--r-- | tools/toollib.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/toollib.c b/tools/toollib.c index bb4a810f..d5ad805a 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -119,6 +119,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd, process_all = 1; } + /* + * FIXME: In case of remove it goes through deleted entries, + * but it works since entries are allocated from vg mem pool. + */ dm_list_iterate_items(lvl, &vg->lvs) { if (lvl->lv->status & SNAPSHOT) continue; @@ -182,6 +186,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd, } if (lvargs_supplied && lvargs_matched != dm_list_size(arg_lvnames)) { + /* + * FIXME: lvm supports removal of LV with all its dependencies + * this leads to miscalculation that depends on the order of args. + */ log_error("One or more specified logical volume(s) not found."); if (ret_max < ECMD_FAILED) ret_max = ECMD_FAILED; |