From 98c92abf4ef5b91638c0c3589b66b88de6b4dc70 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Sun, 4 Mar 2012 15:58:31 +0000 Subject: Add FIXMEs Processing loop needs some thinking --- tools/toollib.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'tools/toollib.c') diff --git a/tools/toollib.c b/tools/toollib.c index bb4a810f..d5ad805a 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -119,6 +119,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd, process_all = 1; } + /* + * FIXME: In case of remove it goes through deleted entries, + * but it works since entries are allocated from vg mem pool. + */ dm_list_iterate_items(lvl, &vg->lvs) { if (lvl->lv->status & SNAPSHOT) continue; @@ -182,6 +186,10 @@ int process_each_lv_in_vg(struct cmd_context *cmd, } if (lvargs_supplied && lvargs_matched != dm_list_size(arg_lvnames)) { + /* + * FIXME: lvm supports removal of LV with all its dependencies + * this leads to miscalculation that depends on the order of args. + */ log_error("One or more specified logical volume(s) not found."); if (ret_max < ECMD_FAILED) ret_max = ECMD_FAILED; -- cgit