diff options
| author | Jonathan Earl Brassow <jbrassow@redhat.com> | 2010-08-06 15:38:32 +0000 |
|---|---|---|
| committer | Jonathan Earl Brassow <jbrassow@redhat.com> | 2010-08-06 15:38:32 +0000 |
| commit | 8d2d4f1fa09b7e751045219802d0b5890dd68f4c (patch) | |
| tree | 917c7606e77b7f1afc14a7b3afa83ab5b51ccda5 /tools/lvconvert.c | |
| parent | 498747d792c93d8f98cdd08631c367d84ec8bdc2 (diff) | |
| download | lvm2-8d2d4f1fa09b7e751045219802d0b5890dd68f4c.tar.gz lvm2-8d2d4f1fa09b7e751045219802d0b5890dd68f4c.tar.xz lvm2-8d2d4f1fa09b7e751045219802d0b5890dd68f4c.zip | |
Fix for bug 619221 - log device splitting regression
An incorrect fix on July 13, 2010 for an annoyance has caused a regression.
The offending check-in was part of the 2.02.71 release of LVM. That
check-in caused any PVs specified on the command line to be ignored when
performing a mirror split.
This patch reverses the aforementioned check-in (solving the regressions)
and posits a new solution to the list reversal problem. The original
problem was that we would always take the lowest mimage LVs from a mirror
when performing a split, but what we really want is to take the highest
mimage LVs. This patch accomplishes that by working through the list in
reverse order - choosing the higher numbered mimages first. (This also
reduces the amount of processing necessary.)
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Reviewed-by: Takahiro Yasui <takahiro.yasui@hds.com>
Diffstat (limited to 'tools/lvconvert.c')
| -rw-r--r-- | tools/lvconvert.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 1f17619e..1be3a8da 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -1015,7 +1015,7 @@ static int _lvconvert_mirrors_aux(struct cmd_context *cmd, lv->le_count, lp->region_size); - if (!operable_pvs && !lp->keep_mimages) + if (!operable_pvs) operable_pvs = lp->pvh; seg = first_seg(lv); |