From 8d2d4f1fa09b7e751045219802d0b5890dd68f4c Mon Sep 17 00:00:00 2001 From: Jonathan Earl Brassow Date: Fri, 6 Aug 2010 15:38:32 +0000 Subject: Fix for bug 619221 - log device splitting regression An incorrect fix on July 13, 2010 for an annoyance has caused a regression. The offending check-in was part of the 2.02.71 release of LVM. That check-in caused any PVs specified on the command line to be ignored when performing a mirror split. This patch reverses the aforementioned check-in (solving the regressions) and posits a new solution to the list reversal problem. The original problem was that we would always take the lowest mimage LVs from a mirror when performing a split, but what we really want is to take the highest mimage LVs. This patch accomplishes that by working through the list in reverse order - choosing the higher numbered mimages first. (This also reduces the amount of processing necessary.) Signed-off-by: Jonathan Brassow Reviewed-by: Takahiro Yasui --- tools/lvconvert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tools/lvconvert.c') diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 1f17619e..1be3a8da 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -1015,7 +1015,7 @@ static int _lvconvert_mirrors_aux(struct cmd_context *cmd, lv->le_count, lp->region_size); - if (!operable_pvs && !lp->keep_mimages) + if (!operable_pvs) operable_pvs = lp->pvh; seg = first_seg(lv); -- cgit