summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* spice: the session is connected when main channel openedMarc-André Lureau2012-11-211-2/+1
| | | | | | | The previous change in 399aae55aa384bf91dff0fc770497c0d5f935fa9 rely on correct session-connected signal. However, the spice backend is emiting it too early, when the main channel is created, where it should wait until it is connected instead.
* "Unable to connect to the graphic server" error on guest shutdownMarc-André Lureau2012-11-201-4/+6
| | | | | | | | | | In virt_viewer_app_activate(), priv->connected is set to FALSE when the connect/active is successfull. However, we rely on it to know whether the virt_viewer_app_disconnected() is an error, so only set it to FALSE when connection failed. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=875697
* build-sys: add min libvirt version requirement checkMarc-André Lureau2012-11-161-1/+1
|
* Make sure png screenshots have a .png extensionsChristophe Fergeau2012-11-151-2/+10
| | | | | | When falling back to saving to .png, the filename might not end with .png. This commit appends the .png extension to the screenshot filename if it's missing.
* Allow to save to other formats than pngChristophe Fergeau2012-11-151-2/+53
| | | | | | Currently, the screenshots can only be saved to png. This commit checks if the file extension is a known one, and will save to this format if it is. Otherwise it will fallback to saving to png.
* Set a default dir/name for screenshotsChristophe Fergeau2012-11-151-3/+5
| | | | | | | It makes sense for the screenshots to be saved in ~/Images, especially as otherwise the filechooser will display 'recent documents' to which we cannot save. This commit also sets the default screenshot name to 'Screenshot'.
* Fix spice-gtk check in configure.acChristophe Fergeau2012-11-151-1/+1
| | | | | | | | The check that at least one of spice-gtk and gtk-vnc is present uses a wrong variable name to check for spice-gtk presence, which causes the check to think it's never present. This would make gtk-vnc presence mandatory. This commit fixes the name of the spice-gtk variable ($have_gtk_spice -> $have_spice_gtk).
* Don't SIGSEGV if no transport is used.Michal Privoznik2012-11-141-1/+1
| | | | | | | | One of previous commits (74b1b62510d939) allowed us to connect to localhost directly if ssh transport was used. However, if there's not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as one of arguments. Change this to g_strcmp0 which does the same service but is more friendly to NULL arguments.
* Reconnect to libvirtd after connection breaksMichal Privoznik2012-11-134-9/+57
| | | | | | | | Currently, if user wants to reconnect to a domain he can use '-r' cmd line argument. This makes virt-viewer listen to domain events. However, if connection to libvirtd breaks somehow, we will receive no longer any event. Hence we must reconnect to the libvirt.
* Connect to localhost for display when transport is sshDave Allan2012-11-081-3/+11
| | | | | | | | | | | When connecting to a VM that does not have a 'listen' tag in its graphcs element, we have to guess where to try to connect to the VM's display. The current default is the host specified in the connection URI which is correct for most transports, however, the SSH transport makes the display connection from the remote end, so in that case, attempt to connect to localhost. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Fail if neither vnc nor spice is detectedGuido Günther2012-10-251-0/+4
| | | | Since the viewer makes little sense otherwise.
* Fix jenkins build failureMarc-André Lureau2012-10-231-0/+1
| | | | | | | | | virt-viewer-util.c: In function 'virt_viewer_util_init': virt-viewer-util.c:289: warning: implicit declaration of function 'setlocale' virt-viewer-util.c:289: warning: nested extern declaration of 'setlocale' virt-viewer-util.c:289: error: 'LC_ALL' undeclared (first use in this function) virt-viewer-util.c:289: error: (Each undeclared identifier is reported only once virt-viewer-util.c:289: error: for each function it appears in.)
* Use a mutex to check if VirtViewer runningMarc-André Lureau2012-10-232-0/+21
| | | | | | | We need to warn user that installer can't proceed if there is already a running instance of VirtViewer or of the installer. https://bugzilla.redhat.com/show_bug.cgi?id=864033
* Use a common early init() functionMarc-André Lureau2012-10-234-32/+36
| | | | | There is a number of things both virt-viewer and remote-viewer need to do early during execution. Do it only in one place.
* windows: add debug-helperMarc-André Lureau2012-10-232-0/+75
| | | | | | | | | | | | This is a simple program that will set some debug variable, and run gdb and wait until it finished. This makes it possible to debug "remote-viewer --spice-controller" easily, by setting the necessary variables and keeping the parent process running (the activex whatches its death) To use it, replace the HKCU "Software\spice-space.org\spicex\client" value "$INSTDIR\bin\remote-viewer.exe --spice-controller" with "$INSTDIR\bin\debug-helper.exe remote-viewer.exe --spice-controller".
* nsis: add deps.txt file in installerMarc-André Lureau2012-10-233-0/+24
| | | | | | This helps track package version that were used during the build of Windows installer. It's not ideal, but make up the lack of package management on windows
* nsis: update required files and librariesMarc-André Lureau2012-10-231-17/+35
|
* win32: there is no CONERR$, only CONOUT$Marc-André Lureau2012-10-232-2/+2
|
* spice: only autoresize once with screen size in fullscreenMarc-André Lureau2012-10-183-2/+38
| | | | | | | | | | | | It's currently not possible to configure guest with higher resolution than native, as it will switch back to native, since the gtk widget allocation will always end up being the size of the screen. We special-case fullscreen mode, and only resize when entering fullscreen. Furthermore, it avoids sending extra unnecessary resize events to the guest whenever gtk+ call size allocate in various stages, with different values. https://bugzilla.redhat.com/show_bug.cgi?id=864929
* spice: avoid rounding issues when scaling up displayMarc-André Lureau2012-10-172-4/+5
| | | | | | | | | | | | Fix some unwanted guest resize due to rounding issues (at least when scaling up) We may want to save the original remote desktop size, instead of always checking widget requisition. That way zooming shouldn't resize guest at all, but it seems tricky to handle that special case vs user window resize that should trigger guest resize. https://bugzilla.redhat.com/show_bug.cgi?id=856678
* Do not resize window to minimum when toggling auto-resizeMarc-André Lureau2012-10-161-6/+7
| | | | | | | | | | | | | | | The virt_viewer_display_idle() will queue a resize event that will result in display size requisition of 50x50. If we later resize the window to 1x1 in virt_viewer_window_resize() we end up with a tiny window. It is legitimate not to force that 1x1 window resize when toggling the option. After the rest of the logic in virt_viewer_window_resize(), if the remote desktop ends up being resize, that will trigger another virt_viewer_set_desktop_size() and finally change the window size appropriately. https://bugzilla.redhat.com/show_bug.cgi?id=856610
* Add RPM magic to run autoreconfDaniel P. Berrange2012-10-121-0/+16
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Fix check for IPv6 any addressDaniel P. Berrange2012-10-101-3/+22
| | | | | | | | | | The string '::' is just one of many possible ways to express the IPv6 "any" address. Others include '::0', '0:0:0:0:0:0:0:0', '0::0' and more. Instead of trying to do strcmp, actually try parsing the address with GInetAddress and then simply use an accessor to check what type it is Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Allow user to set a window title for remote-viewerDaniel P. Berrange2012-10-096-8/+35
| | | | | | | | | Currently the remote viewer windows get the URI as their title. Provide a --title STRING arg to remote-viewer to let the user override the title with something more meaningful to them. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Don't free SPICE ticket twiceChristophe Fergeau2012-10-011-1/+0
| | | | | | | Commit 2201a5a was supposed to free a SPICE ticket leak, but it's actually introducing a double-free as the SPICE ticket is unconditionally freed at the end of virt_viewer_session_spice_main_channel_event
* Append \n to message in virt_viewer_app_traceChristophe Fergeau2012-09-182-12/+13
| | | | | | | Callers manually add a trailing \n when they call virt_viewer_app_trace, but it's sometimes forgotten, leading to rhbz#822794. This commit removes the \n from all callers (it was missing in a few of them) and adds it in virt_viewer_app_trace.
* Refresh translationsDaniel P. Berrange2012-09-1855-4462/+13868
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Update for 0.5.4 releaev0.5.4Daniel P. Berrange2012-09-174-3/+18
|
* Use a more specific regex to fix enum include pathsDaniel P. Berrange2012-09-141-1/+1
| | | | | | Simply doing a search replace on $(srcdir) doesn't work very well in non-VPATH builds. Use a more specific regex that won't generate false matches
* Look in builddir for icons & strip build dir prefix from enum file includsDaniel P. Berrange2012-09-141-2/+4
|
* Don't include generated icons in tar.gz and clean them upDaniel P. Berrange2012-09-141-2/+1
|
* Convert to use Mingw64 toolchain for Windows biuldsDaniel P. Berrange2012-09-144-103/+145
|
* Document -f=auto-conf in remote-viewer --helpChristophe Fergeau2012-08-131-1/+1
| | | | | | virt-viewer does not support -f=auto-conf so this does not change the option there. Fixes rhbz#718001
* Use real binary name in help messageChristophe Fergeau2012-08-102-7/+15
| | | | | | | | | | | | Now that we have 2 distinct binaries, remote-viewer and virt-viewer, 'PACKAGE' can no longer be used in error messages as the name of the binary. This causes a small inconsistency when running 'remote-viewer --foobar' as the error message would be: 'Unknown option --foobar Run 'virt-viewer --help' to see a full list of available command line options' This commit makes sure we use argv[0] for this message. Fixes rhbz#814150
* Show status page by default if display not readyMarc-André Lureau2012-07-231-1/+5
| | | | Switch back to status page if display is not ready.
* Make status widget visible immediatelyMarc-André Lureau2012-07-231-0/+1
| | | | | | | | | | GtkNotebook will use the currently visible widget as default page. If we don't show status widget before we append the display, the current page will be on display. Quoting Gtk+ documentation: "Note that due to historical reasons, GtkNotebook refuses to switch to a page unless the child widget is visible. Therefore, it is recommended to show child widgets before adding them to a notebook."
* vnc: when session is disconnected, make the display as non-readyMarc-André Lureau2012-07-231-3/+3
|
* Simplify display flag handlingMarc-André Lureau2012-07-234-20/+13
|
* Add VirtViewerSession::session-display-updatedMarc-André Lureau2012-07-234-4/+34
| | | | | Rebuild menu when agent is connected. Only when the agent is running may a display be enabled/disabled.
* Make the display submenu insensitive if display can't be selectedMarc-André Lureau2012-07-231-1/+17
|
* spice: factor out main channel lookup codeMarc-André Lureau2012-07-231-5/+17
|
* Add VirtViewerDisplay::selectable propertyMarc-André Lureau2012-07-233-0/+41
| | | | | | | This property will be set when the display can be selected to be "enabled" and shown (this can involve creating/connecting an additional guest monitor, and may need guest agent cooperation for example).
* Add virt_viewer_window_get_display()Marc-André Lureau2012-07-232-2/+12
| | | | Getter used in following changes.
* Hook up handling of MonitorsMarc-André Lureau2012-07-233-19/+92
| | | | | | Rely on spice-gtk display channel monitors property to manage displays. The same display channel may now provide several monitors, the SpiceDisplay widget must be told which monitor to display
* Bump glib > 2.22, add compat fileMarc-André Lureau2012-07-235-1/+60
| | | | | We use API from 2.22, and some from further version. Add virt-glib-compat.h fallback file for those.
* Use SpiceDisplay:ready property instead of channel markMarc-André Lureau2012-07-231-23/+15
| | | | | | The display can now check several conditions before the display can be shown, use that instead of display mark, which was not high-level enough.
* Number display starting from 1Marc-André Lureau2012-07-231-1/+1
|
* Prevent from adding the same display several time in the sessionMarc-André Lureau2012-07-231-0/+3
| | | | | In virt_viewer_session_spice_display_monitors(), we (re)add the display unconditionnaly every time we receive a new MonitorConfig.
* Add a DISABLED display hintMarc-André Lureau2012-07-235-5/+56
| | | | | | | | This flag will help to track whether the display has been removed/closed and whether it really has a valid display. Ready in contrast, is used to "hide" temporarily the display (when starting or redrawing the display, to avoid artifacts)
* Use virt_viewer_connect_object() for displayMarc-André Lureau2012-07-232-14/+14
| | | | | | | When display is released, detach signal automatically. Fix various crash related to not cleaning up signal handlers properly, due to no longer 1-1 only relation between display widget and channel.