Cleaned up DefStore.processRequest() (part 2).

An if-statement in DefStore.processRequest() has been modified
to return early for clarity. The code indentation has been adjusted
accordingly.

https://pagure.io/dogtagpki/issue/2652

Change-Id: Ife5a1e3c2d4a09a687acc2714948b670fd31bfe3

1 files changed, 17 insertions, 14 deletions

diff --git a/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java b/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java
index 9882acd3a..0b29b0830 100644
--- a/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java
+++ b/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java
@@ -535,23 +535,26 @@ public class DefStore implements IDefStore, IExtendedPluginInfo {
                     }
                 }
 
-            } else {
-                CMS.debug("DefStore: evaluating x509 crl impl");
-                X509CRLEntry crlentry = theCRL.getRevokedCertificate(new BigInteger(serialNo.toString()));
-
-                if (crlentry == null) {
-                    // good or unknown
-                    if (isNotFoundGood()) {
-                        certStatus = new GoodInfo();
-                    } else {
-                        certStatus = new UnknownInfo();
-                    }
-                } else {
-                    certStatus = new RevokedInfo(new GeneralizedTime(
-                                    crlentry.getRevocationDate()));
+                return new SingleResponse(cid, certStatus, thisUpdate,
+                        nextUpdate);
+            }
+
+            CMS.debug("DefStore: evaluating x509 crl impl");
+            X509CRLEntry crlentry = theCRL.getRevokedCertificate(new BigInteger(serialNo.toString()));
 
+            if (crlentry == null) {
+                // good or unknown
+                if (isNotFoundGood()) {
+                    certStatus = new GoodInfo();
+                } else {
+                    certStatus = new UnknownInfo();
                 }
+            } else {
+                certStatus = new RevokedInfo(new GeneralizedTime(
+                                crlentry.getRevocationDate()));
+
             }
+
             return new SingleResponse(cid, certStatus, thisUpdate,
                     nextUpdate);