diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2017-05-24 06:48:58 +0200 |
|---|---|---|
| committer | Endi S. Dewata <edewata@redhat.com> | 2017-05-24 18:54:19 +0200 |
| commit | 4511646ecec5b99dfb0ab31fc604a8765313941e (patch) | |
| tree | 93a12950e08e343d4f0dd334fba51711a3697c3d /base/server/cms/src | |
| parent | f6cc8db2fbd9ab509c4285e944306b31cf068a5f (diff) | |
Cleaned up DefStore.processRequest() (part 2).
An if-statement in DefStore.processRequest() has been modified
to return early for clarity. The code indentation has been adjusted
accordingly.
https://pagure.io/dogtagpki/issue/2652
Change-Id: Ife5a1e3c2d4a09a687acc2714948b670fd31bfe3
Diffstat (limited to 'base/server/cms/src')
| -rw-r--r-- | base/server/cms/src/com/netscape/cms/ocsp/DefStore.java | 31 |
1 files changed, 17 insertions, 14 deletions
diff --git a/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java b/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java index 9882acd3a..0b29b0830 100644 --- a/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java +++ b/base/server/cms/src/com/netscape/cms/ocsp/DefStore.java @@ -535,23 +535,26 @@ public class DefStore implements IDefStore, IExtendedPluginInfo { } } - } else { - CMS.debug("DefStore: evaluating x509 crl impl"); - X509CRLEntry crlentry = theCRL.getRevokedCertificate(new BigInteger(serialNo.toString())); - - if (crlentry == null) { - // good or unknown - if (isNotFoundGood()) { - certStatus = new GoodInfo(); - } else { - certStatus = new UnknownInfo(); - } - } else { - certStatus = new RevokedInfo(new GeneralizedTime( - crlentry.getRevocationDate())); + return new SingleResponse(cid, certStatus, thisUpdate, + nextUpdate); + } + + CMS.debug("DefStore: evaluating x509 crl impl"); + X509CRLEntry crlentry = theCRL.getRevokedCertificate(new BigInteger(serialNo.toString())); + if (crlentry == null) { + // good or unknown + if (isNotFoundGood()) { + certStatus = new GoodInfo(); + } else { + certStatus = new UnknownInfo(); } + } else { + certStatus = new RevokedInfo(new GeneralizedTime( + crlentry.getRevocationDate())); + } + return new SingleResponse(cid, certStatus, thisUpdate, nextUpdate); |