Refactored UpdateCRL.process() (part 3).

The UpdateCRL.process() has been refactored to reduce deeply
nested if-statements with early return.

https://pagure.io/dogtagpki/issue/2651

Change-Id: Ie3aa5f9154eec78e994cf89cc33616d2c5cbaf47

1 files changed, 4 insertions, 2 deletions

diff --git a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
index 86693610a..ca4a5bfef 100644
--- a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
+++ b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
@@ -436,14 +436,17 @@ public class UpdateCRL extends CMSServlet {
 
                     mTesting.remove(crlIssuingPointId);
                     CMS.debug("CRL test finished.");
+                    return;
                 } else if (test != null && test.equals("true") &&
                            crlIssuingPoint.isCRLCacheTestingEnabled() &&
                            mTesting.contains(crlIssuingPointId)) {
                     header.addStringValue("crlUpdate", "testingInProgress");
+                    return;
                 } else if (test != null && test.equals("true") &&
                            (!crlIssuingPoint.isCRLCacheTestingEnabled())) {
                     header.addStringValue("crlUpdate", "testingNotEnabled");
-                } else {
+                    return;
+                }
                     try {
                         EBaseException publishError = null;
 
@@ -526,6 +529,5 @@ public class UpdateCRL extends CMSServlet {
                             throw e;
                         }
                     }
-                }
     }
 }