diff options
author | Endi S. Dewata <edewata@redhat.com> | 2017-05-17 19:43:06 +0200 |
---|---|---|
committer | Endi S. Dewata <edewata@redhat.com> | 2017-05-17 19:57:31 +0200 |
commit | ce9e6f1704d6c821429faafc778358202e1a233e (patch) | |
tree | e82041626f044ebbe13c6bb1316d0bffd28db480 /base/server/cms/src/com | |
parent | 69d5dc82f8664d1eb5dfcdcec615088127c0ad97 (diff) | |
download | pki-ce9e6f1704d6c821429faafc778358202e1a233e.tar.gz pki-ce9e6f1704d6c821429faafc778358202e1a233e.tar.xz pki-ce9e6f1704d6c821429faafc778358202e1a233e.zip |
Refactored UpdateCRL.process() (part 3).
The UpdateCRL.process() has been refactored to reduce deeply
nested if-statements with early return.
https://pagure.io/dogtagpki/issue/2651
Change-Id: Ie3aa5f9154eec78e994cf89cc33616d2c5cbaf47
Diffstat (limited to 'base/server/cms/src/com')
-rw-r--r-- | base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java index 86693610a..ca4a5bfef 100644 --- a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java +++ b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java @@ -436,14 +436,17 @@ public class UpdateCRL extends CMSServlet { mTesting.remove(crlIssuingPointId); CMS.debug("CRL test finished."); + return; } else if (test != null && test.equals("true") && crlIssuingPoint.isCRLCacheTestingEnabled() && mTesting.contains(crlIssuingPointId)) { header.addStringValue("crlUpdate", "testingInProgress"); + return; } else if (test != null && test.equals("true") && (!crlIssuingPoint.isCRLCacheTestingEnabled())) { header.addStringValue("crlUpdate", "testingNotEnabled"); - } else { + return; + } try { EBaseException publishError = null; @@ -526,6 +529,5 @@ public class UpdateCRL extends CMSServlet { throw e; } } - } } } |