diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2019-06-09 13:31:31 +0300 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2019-06-14 16:50:32 +0000 |
| commit | 0a6fe8551ac9807a8b6ad62241ec8048cf9f9025 (patch) | |
| tree | 7f6d6b7920ed775c75ca7b4a3dd14aceef5eec38 /xlators/features/quota/src | |
| parent | 65e3624091e895ca32cd91468552589f34d17595 (diff) | |
| download | glusterfs-0a6fe8551ac9807a8b6ad62241ec8048cf9f9025.tar.gz glusterfs-0a6fe8551ac9807a8b6ad62241ec8048cf9f9025.tar.xz glusterfs-0a6fe8551ac9807a8b6ad62241ec8048cf9f9025.zip | |
multiple files: another attempt to remove includes
There are many include statements that are not needed.
A previous more ambitious attempt failed because of *BSD plafrom
(see https://review.gluster.org/#/c/glusterfs/+/21929/ )
Now trying a more conservative reduction.
It does not solve all circular deps that we have, but it
does reduce some of them. There is just too much to handle
reasonably (dht-common.h includes dht-lock.h which includes
dht-common.h ...), but it does reduce the overall number of lines
of include we need to look at in the future to understand and fix
the mess later one.
Change-Id: I550cd001bdefb8be0fe67632f783c0ef6bee3f9f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'xlators/features/quota/src')
| -rw-r--r-- | xlators/features/quota/src/quota.c | 4 | ||||
| -rw-r--r-- | xlators/features/quota/src/quota.h | 3 | ||||
| -rw-r--r-- | xlators/features/quota/src/quotad.c | 1 |
3 files changed, 0 insertions, 8 deletions
diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c index c787028e7b..c014c99cbd 100644 --- a/xlators/features/quota/src/quota.c +++ b/xlators/features/quota/src/quota.c @@ -7,13 +7,9 @@ later), or the GNU General Public License, version 2 (GPLv2), in all cases as published by the Free Software Foundation. */ -#include <fnmatch.h> #include "quota.h" -#include <glusterfs/common-utils.h> -#include <glusterfs/defaults.h> #include <glusterfs/statedump.h> -#include <glusterfs/quota-common-utils.h> #include "quota-messages.h" #include <glusterfs/events.h> diff --git a/xlators/features/quota/src/quota.h b/xlators/features/quota/src/quota.h index a5a99cac09..00012c22f4 100644 --- a/xlators/features/quota/src/quota.h +++ b/xlators/features/quota/src/quota.h @@ -10,10 +10,7 @@ #ifndef _QUOTA_H #define _QUOTA_H -#include <glusterfs/xlator.h> #include <glusterfs/call-stub.h> -#include <glusterfs/defaults.h> -#include <glusterfs/common-utils.h> #include "quota-mem-types.h" #include <glusterfs/glusterfs.h> #include <glusterfs/compat.h> diff --git a/xlators/features/quota/src/quotad.c b/xlators/features/quota/src/quotad.c index 146ec74993..643f25c9c2 100644 --- a/xlators/features/quota/src/quotad.c +++ b/xlators/features/quota/src/quotad.c @@ -9,7 +9,6 @@ */ #include "quota.h" #include "quotad-aggregator.h" -#include <glusterfs/common-utils.h> int qd_notify(xlator_t *this, int32_t event, void *data, ...) |