diff options
author | mohit84 <moagrawa@redhat.com> | 2021-04-22 18:56:28 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-22 18:56:28 +0530 |
commit | 5cbf5d94c719d1c7674a59c8009660197fc56af2 (patch) | |
tree | 3b1da66b522712b6602a3bca4d83fcd324daf9a7 /xlators/features/index | |
parent | 7feaeeabd3ad0b1410e78f584b7c5bbfb41ae0e6 (diff) | |
download | glusterfs-release-9.tar.gz glusterfs-release-9.tar.xz glusterfs-release-9.zip |
core: Avoid several dict OR key is NULL message in brick logs (#2344)release-9
Problem: dict_get_with_ref throw a message "dict or key is NULL"
if dict or key is NULL.
Solution: Before access a key check if dictionary is valid.
> Fixes: #1909
> Change-Id: I50911679142b52f854baf20c187962a2a3698f2d
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
> Cherry picked from commit de1b26d68e31b029a59e59a47b51a7e3e6fbfe22
> Reviewed on upstream link https://github.com/gluster/glusterfs/pull/1910
Fixes: #1909
Change-Id: I50911679142b52f854baf20c187962a2a3698f2d
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Diffstat (limited to 'xlators/features/index')
-rw-r--r-- | xlators/features/index/src/index.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/features/index/src/index.c b/xlators/features/index/src/index.c index 4abb2c73ce..f70f185b5b 100644 --- a/xlators/features/index/src/index.c +++ b/xlators/features/index/src/index.c @@ -2134,7 +2134,7 @@ index_fstat(call_frame_t *frame, xlator_t *this, fd_t *fd, dict_t *xdata) int ret = -1; char *flag = NULL; - ret = dict_get_str(xdata, "link-count", &flag); + ret = dict_get_str_sizen(xdata, "link-count", &flag); if ((ret == 0) && (strcmp(flag, GF_XATTROP_INDEX_COUNT) == 0)) { STACK_WIND(frame, index_fstat_cbk, FIRST_CHILD(this), FIRST_CHILD(this)->fops->fstat, fd, xdata); |