summaryrefslogtreecommitdiffstats
path: root/tests/basic/mpx-compat.t
diff options
context:
space:
mode:
authorShyamsundarR <srangana@redhat.com>2018-08-11 13:21:36 -0400
committerAtin Mukherjee <amukherj@redhat.com>2018-08-13 03:00:48 +0000
commit48b93c292c0069da9ac2fe77e66d08a1cdeacfdc (patch)
treef2567d48fe45bde861db28328740d2948fbda53f /tests/basic/mpx-compat.t
parent488dcc17b76b1b46c13ccd269b7a092c014a4d94 (diff)
downloadglusterfs-48b93c292c0069da9ac2fe77e66d08a1cdeacfdc.tar.gz
glusterfs-48b93c292c0069da9ac2fe77e66d08a1cdeacfdc.tar.xz
glusterfs-48b93c292c0069da9ac2fe77e66d08a1cdeacfdc.zip
tests: Fix cleanup routine for some mux tests
Some of the mux tests, set a trap to catch test exit and call cleanup. This will cause cleanup to be invoked twice in case the test times out, or even otherwise, as include.rc also sets a trap to cleanup on exit (TERM and others). This leads to the tarballs generated on failures for these tests to be empty and does not aid debugging. This patch corrects this pattern across the tests to the more standard cleanup at the end. Fixes: bz#1615037 Change-Id: Ib83aeb09fac2aa591b390b9fb9e1f605bfef9a8b Signed-off-by: ShyamsundarR <srangana@redhat.com>
Diffstat (limited to 'tests/basic/mpx-compat.t')
-rw-r--r--tests/basic/mpx-compat.t4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/basic/mpx-compat.t b/tests/basic/mpx-compat.t
index 453011c015..baf629dbf9 100644
--- a/tests/basic/mpx-compat.t
+++ b/tests/basic/mpx-compat.t
@@ -23,8 +23,6 @@ function count_brick_pids {
cleanup
TEST glusterd
TEST $CLI volume set all cluster.brick-multiplex yes
-push_trapfunc "$CLI volume set all cluster.brick-multiplex off"
-push_trapfunc "cleanup"
# Create two vanilla volumes.
TEST $CLI volume create $V0 $H0:$B0/brick-${V0}-{0,1}
@@ -51,3 +49,5 @@ TEST $CLI volume start $V1
# There should be two processes this time (can't share protocol/server).
EXPECT_WITHIN $PROCESS_UP_TIMEOUT "2" count_processes
+
+cleanup; \ No newline at end of file