diff options
| author | Vikas Gorur <vikas@gluster.com> | 2010-04-04 14:11:26 +0000 |
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2010-04-04 22:27:04 -0700 |
| commit | d90c2f86ca7a8f6660e98da1e48c4798539b7d51 (patch) | |
| tree | 2c0bab231490147b95d488cb097b8edd56670cea /libglusterfs/src/stack.h | |
| parent | 9c2bfa8a4441d27178f3b843bfa0a77df9f867e5 (diff) | |
| download | glusterfs-d90c2f86ca7a8f6660e98da1e48c4798539b7d51.tar.gz glusterfs-d90c2f86ca7a8f6660e98da1e48c4798539b7d51.tar.xz glusterfs-d90c2f86ca7a8f6660e98da1e48c4798539b7d51.zip | |
core: Do internal latency measurement of FOPs.
This patch adds a facility by which each translator
keeps track of the average latency of a FOP from
its point of view. That is, the duration between
the translator handing over the call to a lower-level
translator and the reply coming back.
The latency measurement is off by default, and can
be toggled by sending SIGUSR2 to the GlusterFS process.
Latency data is printed as part of the process state dump.
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 268 (Add timing instrumentation code)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=268
Diffstat (limited to 'libglusterfs/src/stack.h')
| -rw-r--r-- | libglusterfs/src/stack.h | 56 |
1 files changed, 54 insertions, 2 deletions
diff --git a/libglusterfs/src/stack.h b/libglusterfs/src/stack.h index cc059f0687..25925f7a69 100644 --- a/libglusterfs/src/stack.h +++ b/libglusterfs/src/stack.h @@ -37,6 +37,8 @@ typedef struct _call_frame_t call_frame_t; struct _call_pool_t; typedef struct _call_pool_t call_pool_t; +#include <sys/time.h> + #include "xlator.h" #include "dict.h" #include "list.h" @@ -76,6 +78,10 @@ struct _call_frame_t { gf_lock_t lock; void *cookie; /* unique cookie */ gf_boolean_t complete; + + glusterfs_fop_t op; + struct timeval begin; /* when this frame was created */ + struct timeval end; /* when this frame completed */ }; struct _call_stack_t { @@ -113,6 +119,16 @@ struct _call_stack_t { } \ } while (0); \ +struct xlator_fops; +struct xlator_mops; + +void +gf_set_fop_from_fn_pointer (call_frame_t *frame, struct xlator_fops *fops, + struct xlator_mops *mops, void *fn); + +void +gf_update_latency (call_frame_t *frame); + static inline void FRAME_DESTROY (call_frame_t *frame) { @@ -130,6 +146,13 @@ FRAME_DESTROY (call_frame_t *frame) static inline void STACK_DESTROY (call_stack_t *stack) { + glusterfs_ctx_t *ctx = get_global_ctx_ptr (); + + if (ctx && ctx->measure_latency) { + gettimeofday (&stack->frames.end, NULL); + gf_update_latency (&stack->frames); + } + LOCK (&stack->pool->lock); { list_del_init (&stack->all_frames); @@ -143,6 +166,10 @@ STACK_DESTROY (call_stack_t *stack) LOCK_DESTROY (&stack->frames.lock); while (stack->frames.next) { + if (ctx && ctx->measure_latency) { + gf_update_latency (stack->frames.next); + } + FRAME_DESTROY (stack->frames.next); } FREE (stack); @@ -173,7 +200,12 @@ STACK_DESTROY (call_stack_t *stack) _new->cookie = _new; \ LOCK_INIT (&_new->lock); \ frame->ref_count++; \ - \ + \ + if (((xlator_t *) obj)->ctx->measure_latency) { \ + gettimeofday (&_new->begin, NULL); \ + gf_set_fop_from_fn_pointer (_new, ((xlator_t *)obj)->fops, ((xlator_t *)obj)->mops, fn); \ + } \ + \ old_THIS = THIS; \ THIS = obj; \ fn (_new, obj, params); \ @@ -203,7 +235,12 @@ STACK_DESTROY (call_stack_t *stack) LOCK_INIT (&_new->lock); \ frame->ref_count++; \ fn##_cbk = rfn; \ - \ + \ + if (((xlator_t *) obj)->ctx->measure_latency) { \ + gettimeofday (&_new->begin, NULL); \ + gf_set_fop_from_fn_pointer (_new, ((xlator_t *)obj)->fops, ((xlator_t *)obj)->mops, fn); \ + } \ + \ old_THIS = THIS; \ THIS = obj; \ fn (_new, obj, params); \ @@ -224,6 +261,11 @@ STACK_DESTROY (call_stack_t *stack) old_THIS = THIS; \ THIS = _parent->this; \ frame->complete = _gf_true; \ + \ + if (((xlator_t *) old_THIS)->ctx->measure_latency) { \ + gettimeofday (&frame->end, NULL); \ + } \ + \ fn (_parent, frame->cookie, _parent->this, params); \ THIS = old_THIS; \ } while (0) @@ -242,6 +284,11 @@ STACK_DESTROY (call_stack_t *stack) old_THIS = THIS; \ THIS = _parent->this; \ frame->complete = _gf_true; \ + \ + if (((xlator_t *) old_THIS)->ctx->measure_latency) { \ + gettimeofday (&frame->end, NULL); \ + } \ + \ fn (_parent, frame->cookie, _parent->this, params); \ THIS = old_THIS; \ } while (0) @@ -294,6 +341,7 @@ static inline call_frame_t * create_frame (xlator_t *xl, call_pool_t *pool) { call_stack_t *stack = NULL; + glusterfs_ctx_t *ctx = get_global_ctx_ptr (); if (!xl || !pool) { return NULL; @@ -316,6 +364,10 @@ create_frame (xlator_t *xl, call_pool_t *pool) LOCK_INIT (&stack->frames.lock); + if (ctx && ctx->measure_latency) { + gettimeofday (&stack->frames.begin, NULL); + } + return &stack->frames; } |