diff options
| author | Pranith Kumar Karampuri <pranith.karampuri@phonepe.com> | 2021-02-04 18:30:26 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-04 18:30:26 +0530 |
| commit | 36d27890e1e0e17c29d4019a44029fd7b4533a23 (patch) | |
| tree | dc6acc992dddaa1218fc8acfc464f2f2ecf54ce3 | |
| parent | 228241e9a02d0a40170efd9a877e8476c0ee2dce (diff) | |
| download | glusterfs-36d27890e1e0e17c29d4019a44029fd7b4533a23.tar.gz glusterfs-36d27890e1e0e17c29d4019a44029fd7b4533a23.tar.xz glusterfs-36d27890e1e0e17c29d4019a44029fd7b4533a23.zip | |
cluster/afr: Change default self-heal-window-size to 1MB (#2113)
At the moment self-heal-window-size is 128KB. This leads to healing data
in 128KB chunks. With the growth of data and the avg file sizes
nowadays, 1MB seems like a better default.
Change-Id: I70c42c83b16c7adb53d6b5762969e878477efb5c
Fixes: #2067
Signed-off-by: Pranith Kumar K <pranith.karampuri@phonepe.com>
| -rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-data.c | 6 | ||||
| -rw-r--r-- | xlators/cluster/afr/src/afr.c | 6 |
2 files changed, 9 insertions, 3 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-data.c b/xlators/cluster/afr/src/afr-self-heal-data.c index f12bca8b34..437d10d1c5 100644 --- a/xlators/cluster/afr/src/afr-self-heal-data.c +++ b/xlators/cluster/afr/src/afr-self-heal-data.c @@ -353,6 +353,12 @@ afr_selfheal_data_do(call_frame_t *frame, xlator_t *this, fd_t *fd, int source, } block = 128 * 1024 * priv->data_self_heal_window_size; + if (HAS_HOLES((&replies[source].poststat))) { + /*Reduce the possibility of data-block allocations in case of files + * with holes. Correct way to fix it would be to use seek fop while + * healing data*/ + block = 128 * 1024; + } type = afr_data_self_heal_type_get(priv, healed_sinks, source, replies); diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index b60b3ed9b9..44aa2aa40b 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -987,12 +987,12 @@ struct volume_options options[] = { .type = GF_OPTION_TYPE_INT, .min = 1, .max = 1024, - .default_value = "1", + .default_value = "8", .op_version = {1}, .flags = OPT_FLAG_CLIENT_OPT | OPT_FLAG_SETTABLE | OPT_FLAG_DOC, .tags = {"replicate"}, - .description = "Maximum number blocks per file for which self-heal " - "process would be applied simultaneously."}, + .description = "Maximum number of 128KB blocks per file for which " + "self-heal process would be applied simultaneously."}, {.key = {"metadata-self-heal"}, .type = GF_OPTION_TYPE_BOOL, .default_value = "off", |