summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRob Crittenden <rcritten@redhat.com>2012-02-10 12:00:35 -0500
committerMartin Kosek <mkosek@redhat.com>2012-02-15 17:27:05 +0100
commitf2da73e3671f38c00f625386a657e5260479d427 (patch)
treec3b8862d1ded9ca13216156ec4d82844deaec518
parentaf52c4d31e0740e0378035119f6463fc13d58737 (diff)
downloadfreeipa-f2da73e3671f38c00f625386a657e5260479d427.tar.gz
freeipa-f2da73e3671f38c00f625386a657e5260479d427.tar.xz
freeipa-f2da73e3671f38c00f625386a657e5260479d427.zip
Correct update syntax in 30-s4u2proxy.update
Always have FQDN available in the update dictionary. There were cases where it would contain the ldapi socket path and not the FQDN. https://fedorahosted.org/freeipa/ticket/2147
-rw-r--r--install/updates/30-s4u2proxy.update2
-rw-r--r--ipaserver/install/ldapupdate.py12
2 files changed, 7 insertions, 7 deletions
diff --git a/install/updates/30-s4u2proxy.update b/install/updates/30-s4u2proxy.update
index 99b7a9cfc..15c3f6165 100644
--- a/install/updates/30-s4u2proxy.update
+++ b/install/updates/30-s4u2proxy.update
@@ -9,7 +9,7 @@ default: objectClass: groupOfPrincipals
default: objectClass: top
default: cn: ipa-http-delegation
default: memberPrincipal: HTTP/$FQDN@$REALM
-default: ipaAllowedTarget: 'cn=ipa-ldap-delegation-targets,cn=s4u2proxy,cn=etc,$SUFFIX'
+default: ipaAllowedTarget: cn=ipa-ldap-delegation-targets,cn=s4u2proxy,cn=etc,$SUFFIX
dn: cn=ipa-ldap-delegation-targets,cn=s4u2proxy,cn=etc,$SUFFIX
default: objectClass: groupOfPrincipals
diff --git a/ipaserver/install/ldapupdate.py b/ipaserver/install/ldapupdate.py
index 8fbfeaf55..a2a94d31d 100644
--- a/ipaserver/install/ldapupdate.py
+++ b/ipaserver/install/ldapupdate.py
@@ -86,11 +86,11 @@ class LDAPUpdate:
domain = ipautil.get_domain_name()
libarch = self.__identify_arch()
- if not self.ldapi:
- fqdn = installutils.get_fqdn()
- if fqdn is None:
- raise RuntimeError("Unable to determine hostname")
- else:
+ fqdn = installutils.get_fqdn()
+ if fqdn is None:
+ raise RuntimeError("Unable to determine hostname")
+ fqhn = fqdn # Save this for the sub_dict variable
+ if self.ldapi:
fqdn = "ldapi://%%2fvar%%2frun%%2fslapd-%s.socket" % "-".join(
self.realm.split(".")
)
@@ -98,7 +98,7 @@ class LDAPUpdate:
if not self.sub_dict.get("REALM") and self.realm is not None:
self.sub_dict["REALM"] = self.realm
if not self.sub_dict.get("FQDN"):
- self.sub_dict["FQDN"] = fqdn
+ self.sub_dict["FQDN"] = fqhn
if not self.sub_dict.get("DOMAIN"):
self.sub_dict["DOMAIN"] = domain
if not self.sub_dict.get("SUFFIX") and suffix is not None: