Clean up spec file (#1242724)

1 files changed, 25 insertions, 14 deletions

diff --git a/perl-File-Find-Rule-Age.spec b/perl-File-Find-Rule-Age.spec
index 4df9c01..8b2cfa2 100644
--- a/perl-File-Find-Rule-Age.spec
+++ b/perl-File-Find-Rule-Age.spec
@@ -6,22 +6,35 @@ License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/File-Find-Rule-Age/
 Source0:        http://www.cpan.org/authors/id/R/RE/REHSACK/File-Find-Rule-Age-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
-BuildRequires:  perl >= 1:v5.8.1
-BuildRequires:  perl(DateTime) >= 0.42
+# Build:
+BuildRequires:  make
+BuildRequires:  findutils
+BuildRequires:  coreutils
+BuildRequires:  perl
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+# Run-time:
+BuildRequires:  perl(DateTime) >= 0.42
 BuildRequires:  perl(File::Find::Rule) >= 0.30
+BuildRequires:  perl(File::stat)
+BuildRequires:  perl(Params::Util) >= 0.37
+# Tests:
 BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(File::Temp)
 BuildRequires:  perl(File::Touch)
-BuildRequires:  perl(Params::Util) >= 0.37
+BuildRequires:  perl(FindBin)
 BuildRequires:  perl(Test::More) >= 0.9
+BuildRequires:  perl(base)
+BuildRequires:  perl(Carp)
 Requires:       perl(DateTime) >= 0.42
 Requires:       perl(File::Find::Rule) >= 0.30
 Requires:       perl(Params::Util) >= 0.37
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
+%global __requires_exclude ^perl\\(DateTime|File::Find::Rule|Params::Util\\)$ 
+
 %description
 File::Find::Rule::Age makes it easy to search for files based on their age.
 DateTime and File::stat are used to do the behind the scenes work, with
@@ -35,27 +48,25 @@ File::Find::Rule doing the Heavy Lifting.
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
 find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT
 
 %check
 make test
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root,-)
-%doc Changes META.json README
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*
 
 %changelog
-* Thu Apr 02 2015 Tim Orling 0.302-1
+* Mon Jul 27 2015 Tim Orling <ticotimo@gmail.com> - 0.302-1
+- Add dependencies from META.json
+- Cleanup spec file per review (#1242724) 
+
+* Thu Apr 02 2015 Tim Orling <ticotimo@gmail.com> - 0.302-1
 - Specfile autogenerated by cpanspec 1.78.