Add some spec improvments from Fedora review

- Add Requires
- Make %description more verbose
- build egg-info with setuptools
- Update Group tag
The Fedora review spec was created by Jussi Lehtola

1 files changed, 19 insertions, 7 deletions

diff --git a/cnucnu.spec b/cnucnu.spec
index 3afe02d..79401db 100644
--- a/cnucnu.spec
+++ b/cnucnu.spec
@@ -4,19 +4,30 @@ Name:           cnucnu
 Version:        0.0.0
 Release:        1%{?dist}
 Summary:        Upstream release monitoring with bug reporting
-
-Group:          Development/Languages
+Group:          Development/Tools
 License:        GPLv2+
 URL:            https://fedoraproject.org/wiki/Upstream_Release_Monitoring
 Source0:        %{name}-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
-BuildArch:      noarch
 BuildRequires:  python-devel
+BuildRequires:  python-setuptools
+BuildArch:      noarch
 
-%description
-Cnucnu provides an upstream release monitoring service.
+Requires: rpm-python
+Requires: python
+Requires: python-bugzilla
+Requires: python-fedora
+Requires: python-genshi
+Requires: python-pycurl
+Requires: python-twisted-core
+Requires: python-twisted-web
+Requires: PyYAML
 
+%description
+Cnucnu provides an upstream release monitoring service with bugzilla
+integration. See more at the project homepage at
+https://fedoraproject.org/wiki/Upstream_Release_Monitoring
 
 %prep
 %setup -q
@@ -28,7 +39,7 @@ Cnucnu provides an upstream release monitoring service.
 
 %install
 rm -rf $RPM_BUILD_ROOT
-%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
+python -c 'import setuptools; execfile("setup.py")' install --skip-build --root %{buildroot}
 
 # remove .py suffix
 mv $RPM_BUILD_ROOT/%{_bindir}/cnucnu{.py,}
@@ -42,7 +53,8 @@ rm -rf $RPM_BUILD_ROOT
 %defattr(-,root,root,-)
 %doc COPYING gpl-2.0.txt gpl-3.0.txt
 # For noarch packages: sitelib
-%{python_sitelib}/*
+%{python_sitelib}/cnucnu/
+%{python_sitelib}/cnucnu-*.egg-info
 %{_bindir}/cnucnu