summaryrefslogtreecommitdiffstats
path: root/tapset
diff options
context:
space:
mode:
Diffstat (limited to 'tapset')
-rw-r--r--tapset/context.stp5
-rw-r--r--tapset/logging.stp8
2 files changed, 6 insertions, 7 deletions
diff --git a/tapset/context.stp b/tapset/context.stp
index 6d600190..4d801956 100644
--- a/tapset/context.stp
+++ b/tapset/context.stp
@@ -12,7 +12,8 @@ function print_backtrace () %{
function backtrace:string () %{
if (CONTEXT->regs) {
- /* XXX: is String really necessary for this? */
+ /* XXX: this won't be necessary when runtime and translator */
+ /* agree on what a string is. */
String str = _stp_string_init (0);
_stp_stack_sprint (str, CONTEXT->regs, 0);
strlcpy (THIS->__retvalue, _stp_string_ptr(str), MAXSTRINGLEN);
@@ -80,8 +81,6 @@ function euid:long () %{
function print_stack(stk:string) %{
char *ptr = THIS->stk;
char *tok = strsep(&ptr, " ");
- /* XXX: is this header really necessary & accurate? */
- _stp_printf ("trace for %d (%s)\n", current->pid, current->comm);
while (tok && *tok) {
_stp_print_cstr(" ");
_stp_symbol_print (simple_strtol(tok, NULL, 16));
diff --git a/tapset/logging.stp b/tapset/logging.stp
index eff7b555..e276aa3f 100644
--- a/tapset/logging.stp
+++ b/tapset/logging.stp
@@ -4,10 +4,10 @@ function print (msg:string) %{
_stp_print (THIS->msg);
%}
-// almost the same as print
-function log (msg) {
- print (msg . "\n")
-}
+// like print but with a newline
+function log (msg:string) %{
+ _stp_printf ("%s\n", THIS->msg);
+%}
function printk (msg:string) %{
printk (KERN_INFO "%s\n", THIS->msg);