summaryrefslogtreecommitdiffstats
path: root/translate.cxx
diff options
context:
space:
mode:
authordsmith <dsmith>2007-03-19 21:14:21 +0000
committerdsmith <dsmith>2007-03-19 21:14:21 +0000
commitab655cf8ec35ab47a38d95182dfe07a0e380681a (patch)
tree64be89f5afc184d87d2b4f2764abc6fc7047ec73 /translate.cxx
parentdc499f36287a8c960f2ccf0d1940b52a8cc62c84 (diff)
downloadsystemtap-steved-ab655cf8ec35ab47a38d95182dfe07a0e380681a.tar.gz
systemtap-steved-ab655cf8ec35ab47a38d95182dfe07a0e380681a.tar.xz
systemtap-steved-ab655cf8ec35ab47a38d95182dfe07a0e380681a.zip
2007-03-19 David Smith <dsmith@redhat.com>
PR 4146 (partial fix) * tapsets.cxx (all_session_groups): Added note about stating that begin probes should be registered (actually run) first and end probes should be unregistered (run) last. * translate.cxx (c_unparser::emit_module_exit): Process probe group vector in reverse order so that probe groups will get unregistered in the reverse order that they were registered.
Diffstat (limited to 'translate.cxx')
-rw-r--r--translate.cxx8
1 files changed, 6 insertions, 2 deletions
diff --git a/translate.cxx b/translate.cxx
index 36530373..89a961e3 100644
--- a/translate.cxx
+++ b/translate.cxx
@@ -1201,9 +1201,13 @@ c_unparser::emit_module_exit ()
// XXX: might like to have an escape hatch, in case some probe is
// genuinely stuck somehow
+ // Notice we're processing the derived_probe_group list in reverse
+ // order. This ensures that probes get unregistered in reverse
+ // order of the way they were registered.
vector<derived_probe_group*> g = all_session_groups (*session);
- for (unsigned i=0; i<g.size(); i++)
- g[i]->emit_module_exit (*session); // NB: runs "end" probes
+ for (vector<derived_probe_group*>::reverse_iterator i = g.rbegin();
+ i != g.rend(); i++)
+ (*i)->emit_module_exit (*session); // NB: runs "end" probes
for (unsigned i=0; i<session->globals.size(); i++)
{