diff options
| author | Frank Ch. Eigler <fche@elastic.org> | 2008-09-01 16:11:04 -0400 |
|---|---|---|
| committer | Frank Ch. Eigler <fche@elastic.org> | 2008-09-01 16:11:04 -0400 |
| commit | 28d29bd38253d73b3d0a0d5ea39b1fe645e66179 (patch) | |
| tree | d2b1b351bcbe4422158984bd5ab284ef3db3bceb /tapsets.cxx | |
| parent | aa3c05113d831a4e5d58287f9f2f9d605bf8693e (diff) | |
| download | systemtap-steved-28d29bd38253d73b3d0a0d5ea39b1fe645e66179.tar.gz systemtap-steved-28d29bd38253d73b3d0a0d5ea39b1fe645e66179.tar.xz systemtap-steved-28d29bd38253d73b3d0a0d5ea39b1fe645e66179.zip | |
test case regression fixes (25444842 vs 84182428)
Diffstat (limited to 'tapsets.cxx')
| -rw-r--r-- | tapsets.cxx | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/tapsets.cxx b/tapsets.cxx index 8f5ed287..0a7ca902 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -5063,8 +5063,8 @@ dwarf_builder::build(systemtap_session & sess, if (! kern_dw) { kern_dw = new dwflpp(sess); - // XXX: PR 3498 - kern_dw->setup_kernel(false); + // XXX: PR 3498, PR 6864 + kern_dw->setup_kernel(true); } dw = kern_dw; } @@ -5595,11 +5595,12 @@ struct itrace_builder: public derived_probe_builder vector<derived_probe *> & finished_results) { string path; - int64_t pid; + int64_t pid = 0; int single_step; bool has_path = get_param (parameters, TOK_PROCESS, path); bool has_pid = get_param (parameters, TOK_PROCESS, pid); + // XXX: PR 6445 needs !has_path && !has_pid support assert (has_path || has_pid); single_step = 1; @@ -5979,8 +5980,6 @@ struct utrace_builder: public derived_probe_builder bool has_pid = get_param (parameters, TOK_PROCESS, pid); enum utrace_derived_probe_flags flags = UDPF_NONE; - assert (has_path || has_pid); - if (has_null_param (parameters, TOK_THREAD)) { if (has_null_param (parameters, TOK_BEGIN)) @@ -6020,6 +6019,8 @@ struct utrace_builder: public derived_probe_builder if (pid < 2) throw semantic_error ("process pid must be greater than 1", location->tok); + + // XXX: could we use /proc/$pid/exe in unwindsym_modules and elsewhere? } finished_results.push_back(new utrace_derived_probe(sess, base, location, @@ -6351,7 +6352,7 @@ utrace_derived_probe_group::emit_module_decls (systemtap_session& s) s.op->newline() << "break;"; s.op->indent(-1); } - + if (flags_seen[UDPF_SYSCALL] || flags_seen[UDPF_SYSCALL_RETURN]) { s.op->newline() << "case UDPF_SYSCALL:"; |