Unify no-component assertions on target variables

There are several tapsets that can't deal with component dereferences on
their target variables, and they all check-and-throw in the same way.
This refactors the checks into a target_symbol member.

* staptree.cxx (target_symbol::assert_no_components): New.
* tapsets.cxx (tracepoint_var_expanding_visitor::visit_target_symbol_arg,
  tracepoint_var_expanding_visitor::visit_target_symbol_context): Use
  the new assertion function to check for no components.
* tapset-mark.cxx (mark_var_expanding_visitor::visit_target_symbol_arg,
  mark_var_expanding_visitor::visit_target_symbol_context): Ditto.
* tapset-perfmon.cxx (perfmon_var_expanding_visitor::visit_target_symbol): Ditto.
* tapset-procfs.cxx (procfs_var_expanding_visitor::visit_target_symbol): Ditto.
* tapset-utrace.cxx (utrace_var_expanding_visitor::visit_target_symbol_arg,
  utrace_var_expanding_visitor::visit_target_symbol_context): Ditto.

1 files changed, 1 insertions, 18 deletions

diff --git a/tapset-procfs.cxx b/tapset-procfs.cxx
index 58bb0f0d..3302057c 100644
--- a/tapset-procfs.cxx
+++ b/tapset-procfs.cxx
@@ -358,24 +358,7 @@ procfs_var_expanding_visitor::visit_target_symbol (target_symbol* e)
     throw semantic_error ("invalid target symbol for procfs probe, $value expected",
                           e->tok);
 
-  if (e->components.size() > 0)
-    {
-      switch (e->components[0].type)
-        {
-        case target_symbol::comp_literal_array_index:
-          throw semantic_error("procfs target variable '$value' may not be used as array",
-                               e->tok);
-          break;
-        case target_symbol::comp_struct_member:
-          throw semantic_error("procfs target variable '$value' may not be used as a structure",
-                               e->tok);
-          break;
-        default:
-          throw semantic_error ("invalid use of procfs target variable '$value'",
-                                e->tok);
-          break;
-        }
-    }
+  e->assert_no_components("procfs");
 
   bool lvalue = is_active_lvalue(e);
   if (write_probe && lvalue)