Unify no-component assertions on target variables

There are several tapsets that can't deal with component dereferences on
their target variables, and they all check-and-throw in the same way.
This refactors the checks into a target_symbol member.

* staptree.cxx (target_symbol::assert_no_components): New.
* tapsets.cxx (tracepoint_var_expanding_visitor::visit_target_symbol_arg,
  tracepoint_var_expanding_visitor::visit_target_symbol_context): Use
  the new assertion function to check for no components.
* tapset-mark.cxx (mark_var_expanding_visitor::visit_target_symbol_arg,
  mark_var_expanding_visitor::visit_target_symbol_context): Ditto.
* tapset-perfmon.cxx (perfmon_var_expanding_visitor::visit_target_symbol): Ditto.
* tapset-procfs.cxx (procfs_var_expanding_visitor::visit_target_symbol): Ditto.
* tapset-utrace.cxx (utrace_var_expanding_visitor::visit_target_symbol_arg,
  utrace_var_expanding_visitor::visit_target_symbol_context): Ditto.

1 files changed, 1 insertions, 18 deletions

diff --git a/tapset-perfmon.cxx b/tapset-perfmon.cxx
index dfdc55e6..d524aa03 100644
--- a/tapset-perfmon.cxx
+++ b/tapset-perfmon.cxx
@@ -67,24 +67,7 @@ perfmon_var_expanding_visitor::visit_target_symbol (target_symbol *e)
   if (e->addressof)
     throw semantic_error("cannot take address of perfmon variable", e->tok);
 
-  if (e->components.size() > 0)
-    {
-      switch (e->components[0].type)
-        {
-        case target_symbol::comp_literal_array_index:
-          throw semantic_error("perfmon probe '$counter' variable may not be used as array",
-                               e->tok);
-          break;
-        case target_symbol::comp_struct_member:
-          throw semantic_error("perfmon probe '$counter' variable may not be used as a structure",
-                               e->tok);
-          break;
-        default:
-          throw semantic_error ("invalid use of perfmon probe '$counter' variable",
-                                e->tok);
-          break;
-        }
-    }
+  e->assert_no_components("perfmon");
 
   ec->code = "THIS->__retvalue = _pfm_pmd_x[" +
           lex_cast<string>(counter_number) + "].reg_num;";