summaryrefslogtreecommitdiffstats
path: root/buildrun.h
diff options
context:
space:
mode:
authorJosh Stone <jistone@redhat.com>2009-09-28 17:36:04 -0700
committerJosh Stone <jistone@redhat.com>2009-09-28 17:36:04 -0700
commit55e50c24c9176f1b3d15af94e145456a68e7ecf6 (patch)
tree4845578ce0a05487078ba81c126797cb26ef035f /buildrun.h
parent5f8ca04fbb0682ff8647b4df5de68cd1042e312d (diff)
downloadsystemtap-steved-55e50c24c9176f1b3d15af94e145456a68e7ecf6.tar.gz
systemtap-steved-55e50c24c9176f1b3d15af94e145456a68e7ecf6.tar.xz
systemtap-steved-55e50c24c9176f1b3d15af94e145456a68e7ecf6.zip
Try to build tracequery for all headers at once
To mitigate PR10424, we switched to building a separate tracequery module for each tracepoint header, so a bad header wouldn't break all of the others. However, with recent kernels that leads to ~18 make commands, which adds up quickly in time. It's cached, so that's not too bad, but as a developer who rebuilds stap frequently, it gets annoying. If we're going to call 18 makes, it's worth it to start with one bigger make that covers all the headers at once (like we used to). If that one fails, we can still fall back to compiling individually. FWIW, the failing ext4.h header was only created in 2.6.31, and was fixed before 2.6.32, so the specific failure in PR10424 has a fairly small window. * buildrun.cxx (make_tracequery): Just take a single vector of headers. * hash.cxx (find_tracequery_hash): Deal with multiple headers. * tapsets.cxx (tracepoint_builder::get_tracequery_module): Ditto. (tracepoint_builder::init_dw): Attempt all system headers together, and if that fails, try again individually.
Diffstat (limited to 'buildrun.h')
-rw-r--r--buildrun.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/buildrun.h b/buildrun.h
index bec81aca..318befd7 100644
--- a/buildrun.h
+++ b/buildrun.h
@@ -15,8 +15,7 @@ int compile_pass (systemtap_session& s);
int run_pass (systemtap_session& s);
int make_tracequery(systemtap_session& s, std::string& name,
- const std::string& header,
- const std::vector<std::string>& extra_headers);
+ const std::vector<std::string>& headers);
int make_typequery(systemtap_session& s, std::string& module);
#endif // BUILDRUN_H